UX: Attaching an image adds an extra "send" button

[andrewmoise]

Issue Description

When I attach an image, I get this:

To me the extra "Send" button isn't really needed (since it'll skip sending the text, and send only the image, whereas the "send" button in the box that's off separated from the attachment box will send both). To me it seems like just removing the duplicate "Send" button (and for that matter maybe coloring the main "send" button in that accent color) would be better.

Expected Behavior

Honestly, I expected either "Send" button to just send the message (image+text+reply attribution, whichever ones exist). But I think it's more logical just to have a single "send" that sends everything (see for example Discord's UI for attaching images).

Actual Behavior

The image attachment "Send" button sends only the image; the text box "Send" icon sends both.

Reproduction Steps

1. Attach an image
2. Write some text
3. Click the "send" button that's accented (the first one your eye finds when looking for an icon to click for "send")

Environement

- OS: NixOS
- Browser: Chromium
- Cinny Web Version: app.cinny.in
- Matrix Homeserver: matrix.org

Relevant Logs

No response

Additional context

No response

I acknowledge that:

• I have searched the Cinny repository (both open and closed Discussions and Issues) and confirm this is not a duplicate of an existing issue or discussion.
• I have checked the "Preview" tab on all text fields to ensure that everything looks right, and have wrapped all configuration and code in code blocks with a group of three backticks (```) on separate lines.

[kfiven]

Hi. It's actually was added as a feature. As file uploads can also be time consuming if files are big enough or server is slow. If we keep the functionality in same button then we'll have to block the input until file uploads is finished and ready to be sent.

[andrewmoise]

Seems like you can still block including the attachment in the message, even if the image box doesn't have its own "Send" button, no? Particularly since it seems like pressing the main "Send" icon will send both the image attachment and the text message... seems like if we're blocking the image from being included in that send-everything action until the upload is complete, we could still do that if the image attachment box's separate Send button didn't exist, right?

Maybe I am misunderstanding something but that's how it seems to me at least.

[kfiven]

If we remove the separate send button for attachments then we'll have to wait for the upload to finish before letting user do anything with the message input send button.

With two buttons gives user idea that the upload is a separate process and will not block you sending message while upload is in process.

I don't know if I am making sense but that was the main idea of adding it.

[andrewmoise]

Yeah, I get that. It does serve that function but also it creates some confusing behavior (at least for new users like myself). If I type a message and also upload an image it's a little weird that there's a button on screen that only sends part of what i sent. You could just have, instead of the separate "send" button, just a badge that shows "Uploading..." and then a checkmark "Ready!" or something indicating the upload status, and then have the main "Send" button work exactly as it normally does (no separate image send button). (Or, another quick fix would be just to make both send buttons the same in terms of sending image content + text content if there is any... but at that point why are there two buttons?)

It's a fairly minor issue in any case -- just speaking up that it surprised me in one minor way and I had to play around with sending a couple test messages before I even really understood what the difference is in how the two send buttons behave.

To the extent it's even an issue, it's only an issue the first time people encounter it before they figure it out, and it also sounds like all of this is to change anyway with some coming changes to how image attachment works in the first place. Cheers + whatever you think on it, I think.