review cyclomatic complexity of Python scripts and refactor where needed

[mmguero]

radon can be used to evaluate the cyclomatic complexity of code and give it a grade (A-F).

For example:

$ radon cc -s shared/bin/extracted_files_http_server.py 
shared/bin/extracted_files_http_server.py
    M 78:4 HTTPHandler.do_GET - F (83)
    C 69:0 HTTPHandler - F (43)
    F 520:0 serve_on_port - A (5)
    F 541:0 main - A (5)
    F 56:0 LocalFilesForZip - A (2)
    M 71:4 HTTPHandler.translate_path - A (1)

We should run this on all our python code (e.g., find . -type f -name "*.py" -print0 | xargs -I "XXX" -0 radon cc -s "XXX") and refactor where necessary.

[mmguero]

cyclomatic complexity

[mmguero]

We'll start with functions with D-F grades:

• ./api/project/__init__.py
  • F 864:0 fields - E (33)
  • F 1045:0 ready - D (30)
• ./dashboards/scripts/index-refresh.py
  • F 37:0 main - F (75)
• ./dashboards/scripts/opensearch_index_size_prune.py
  • F 28:0 main - F (45)
• ./filebeat/scripts/clean-processed-folder.py
  • F 111:0 pruneFiles - E (34)
• ./hedgehog-iso/config/includes.chroot/usr/local/bin/configure-capture.py
  • F 356:0 main - F (229)
  • F 252:0 input_opensearch_connection_info - D (25)
• ./hedgehog-iso/interface/sensor_interface/routes.py
  • F 72:0 update_stats - D (25)
• ./netbox/scripts/netbox_init.py
  • F 110:0 main - F (113)
• ./netbox/scripts/netbox_install_plugins.py
  • F 249:0 install_plugins - E (32)
• ./scripts/control.py
  • F 1508:0 authSetup - F (253) (not doing now because this will eventually be handled by configuration overhaul - auth_setup #768)
  • F 2777:0 main - F (78)
  • F 165:0 checkEnvFilesAndValues - F (63)
  • F 441:0 keystore_op - F (52)
  • F 1238:0 start - D (30)
  • F 1094:0 stop - D (29)
  • F 823:0 netboxRestore - D (25)
  • F 979:0 logs - D (25)
• ./scripts/github-download-counts/github_download_counts.py
  • F 29:0 main - F (56)
• ./scripts/install.py (not doing now because of configuration overhaul - backend and CLI interfaces #395)
• ./scripts/malcolm_common.py
  • F 1125:0 ProcessLogLine - F (41)
  • F 350:0 YesOrNo - E (39)
  • F 615:0 ChooseMultiple - E (34)
  • F 546:0 ChooseOne - D (30)
• ./scripts/malcolm_kubernetes.py
  • F 688:0 StartMalcolm - F (103)
  • F 510:0 PodExec - E (33)
• ./scripts/zeek_script_to_malcolm_boilerplate.py
  • F 174:0 main - F (70)
• ./shared/bin/configure-interfaces.py
  • F 174:0 main - F (83)
• ./shared/bin/extracted_files_http_server.py
  • M 78:4 HTTPHandler.do_GET - F (83)
  • C 69:0 HTTPHandler - F (43)
• ./shared/bin/os-disk-config.py
  • F 194:0 main - F (107)
• ./shared/bin/pcap_processor.py
  • F 390:0 suricataFileWorker - E (40)
  • F 246:0 zeekFileWorker - E (32)
  • F 126:0 arkimeCaptureFileWorker - E (31)
  • F 555:0 main - D (25)
• ./shared/bin/pcap_watcher.py
  • F 275:0 main - E (32)
• ./shared/bin/suricata_config_populate.py
  • F 660:0 main - F (93)
• ./shared/bin/watch_common.py
  • M 68:4 FileOperationEventHandler.on_any_event - E (38)
• ./shared/bin/zeek_carve_logger.py
  • F 74:0 main - E (38)
• ./shared/bin/zeek_carve_scanner.py
  • F 111:0 scanFileWorker - D (27)
• ./shared/bin/zeek_carve_watcher.py
  • F 132:0 main - D (24)
• ./shared/bin/zeek_iana_lookup_generator.py
  • F 63:0 processCsv - D (21)
• ./shared/bin/zeek_intel_from_threat_feed.py
  • F 29:0 main - D (25)
• ./shared/bin/zeek_threat_feed_utils.py
  • F 924:0 UpdateFromMISP - F (64)
  • M 822:4 FeedParserZeekPrinter.ProcessMISP - F (51)
  • F 230:0 map_mandiant_indicator_to_zeek - E (40)
  • F 1375:0 ProcessThreatInputWorker - E (38)
  • F 504:0 map_stix_indicator_to_zeek - E (32)
  • F 609:0 map_misp_attribute_to_zeek - D (21)