Skip to content

ScubaGear needs to determine the M365Environment dynamically so that interactive authentication work without crashing for all of the products #2201

@tkol2022

Description

@tkol2022

Prerequisites

  • This issue has an informative and human-readable title.

💡 Summary

#2147 enhanced ScubaGear to automatically detect the M365Environment so that the user does not need to pass it as a command line parameter anymore when performing non-interactive authentication. This issue is to complete the implementation of that enhancement by making it work for interactive authentication. The goal is that a ScubaGear user won't have to pass M365Environment anymore, period.

Motivation and context

  • Minimize the number of parameters that a user must pass to ScubaGear (make it easier to use)
  • By automatically detecting the M365Environment there is less of a chance that ScubaGear will crash if the user forgets to pass the parameter or passes a wrong value.
  • Since ScubaGear has moved to direct REST APIs and incorporated Power BI, there is more of a need to ensure that the M365Environment parameter is correct so that generating the tokens for the respective products using MSAL will know which target product URIs are needed for the JWT.

Implementation notes

  1. To implement this, it may require some strategic design changes that need to be reviewed and discussed with the team first. See comments below for more information including a rundown of prototyping already performed respective to this issue.
  2. The assignee should conference with @tkol2022 to discuss history before starting the work.

Acceptance criteria

  • Developer has completed the actions above and thoroughly tested the solution.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementThis issue or pull request will add new or improve existing functionality

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions