Adjust key check

mcdonnnj · mcdonnnj · commit 92a7e7db8d55 · 2026-03-18T15:06:54.000-04:00
diff --git a/.github/workflows/verify.yml b/.github/workflows/verify.yml
@@ -102,16 +102,14 @@ jobs:
             const outputVersions = JSON.parse(process.env.ACTION_OUTPUTS)
             var failedChecks = 0
             for (const [key, value] of Object.entries(toolVersions)) {
-              if (key + "-version" in outputVersions === false) {
+              if (!Object.hasOwn(outputVersions, key + "-version")) {
                 console.error("Missing " + key + "-version value")
                 failedChecks++
               }
               if (outputVersions[key + "-version"] !== value) {
                 console.error("Mismatched versions for " + key)
               }
             }
-            console.error("Forcing failure")
-            failedChecks++
             if (failedChecks > 0) {
               core.setFailed("Verification failed")
             }

Original file line number	Diff line number	Diff line change
`@@ -102,16 +102,14 @@ jobs:`
`102`	`102`	`const outputVersions = JSON.parse(process.env.ACTION_OUTPUTS)`
`103`	`103`	`var failedChecks = 0`
`104`	`104`	`for (const [key, value] of Object.entries(toolVersions)) {`
`105`		`- if (key + "-version" in outputVersions === false) {`
	`105`	`+ if (!Object.hasOwn(outputVersions, key + "-version")) {`
`106`	`106`	`console.error("Missing " + key + "-version value")`
`107`	`107`	`failedChecks++`
`108`	`108`	`}`
`109`	`109`	`if (outputVersions[key + "-version"] !== value) {`
`110`	`110`	`console.error("Mismatched versions for " + key)`
`111`	`111`	`}`
`112`	`112`	`}`
`113`		`- console.error("Forcing failure")`
`114`		`- failedChecks++`
`115`	`113`	`if (failedChecks > 0) {`
`116`	`114`	`core.setFailed("Verification failed")`
`117`	`115`	`}`