Skip to content

tweak(extra-natives-five): sanitize blip natives #3311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

n3xuuu
Copy link
Contributor

@n3xuuu n3xuuu commented Apr 1, 2025

Goal of this PR

This pull request aims to patch specific native functions related to blip handling in the game. It ensures that the natives ADD_TEXT_COMPONENT_SUBSTRING_BLIP_NAME and DOES_BLIP_EXIST can handle invalid blip IDs.

From what I've tested, only those two natives threw an error when used.

How is this PR achieving the goal

Added a check to ensure the blipId argument is not less than 0.

This PR applies to the following area(s)

FiveM, Natives

Successfully tested on

Game builds: -

Platforms: Windows, Linux

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

Fixes #3307

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Apr 1, 2025
fix(extra-natives-five): fixed issue with handler
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Apr 1, 2025
@n3xuuu n3xuuu closed this Apr 17, 2025
@github-actions github-actions bot added invalid Requires changes before it's considered valid and can be (re)triaged and removed triage Needs a preliminary assessment to determine the urgency and required action labels Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Requires changes before it's considered valid and can be (re)triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception with blip natives
1 participant