remove extra check when delete idea (#464)

ilmartyrk · DiverVM · web-flow · commit 3267e93075d4 · 2025-04-28T18:41:46.000+03:00
Co-authored-by: Viktar Maslouski &lt;diver.vm@gmail.com&gt;
diff --git a/routes/api/ideation.js b/routes/api/ideation.js
@@ -907,7 +907,6 @@ module.exports = function (app) {
             const ideaId = req.params.ideaId;
             const ideationId = req.params.ideationId;
             const topicId = req.params.topicId;
-            const sessToken = createHash('sha256').update(req.cookies[config.session.name]).digest('base64');
             const idea = await Idea.findOne({
                 where: {
                     id: ideaId
@@ -934,7 +933,7 @@ module.exports = function (app) {
                 res.forbidden();
             }
 
-            if ((!ideation.allowAnonymous && idea.authorId !== req.user.id) || (ideation.allowAnonymous && idea.sessionId !== sessToken)) {
+            if (idea.authorId !== req.user.id) {
                 return res.forbidden();
             }
 

Original file line number	Diff line number	Diff line change
`@@ -907,7 +907,6 @@ module.exports = function (app) {`
`907`	`907`	`const ideaId = req.params.ideaId;`
`908`	`908`	`const ideationId = req.params.ideationId;`
`909`	`909`	`const topicId = req.params.topicId;`
`910`		`- const sessToken = createHash('sha256').update(req.cookies[config.session.name]).digest('base64');`
`911`	`910`	`const idea = await Idea.findOne({`
`912`	`911`	`where: {`
`913`	`912`	`id: ideaId`
`@@ -934,7 +933,7 @@ module.exports = function (app) {`
`934`	`933`	`res.forbidden();`
`935`	`934`	`}`
`936`	`935`
`937`		`- if ((!ideation.allowAnonymous && idea.authorId !== req.user.id) \|\| (ideation.allowAnonymous && idea.sessionId !== sessToken)) {`
	`936`	`+ if (idea.authorId !== req.user.id) {`
`938`	`937`	`return res.forbidden();`
`939`	`938`	`}`
`940`	`939`