Skip to content

Commit 638b831

Browse files
authored
Merge pull request #338 from citizensadvice/CLOUD-733_require_fixed_versions_so_dependency_tree_is_correct_in_downstream
CLOUD-733: Require fixed versions so dependency tree is correct in downstream
2 parents 1278981 + 268dca4 commit 638b831

2 files changed

Lines changed: 20 additions & 13 deletions

File tree

pyproject.toml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,17 @@ requires-python = ">=3.10"
66
license = { file = "LICENSE" }
77
authors = [{ name = "Citizens Advice", email = "cloud.engineering@citizensadvice.org.uk" }]
88
dependencies = [
9-
"aws-cdk-lib>=2.215,<3.0",
109
"cdk8s>=2.70.15,<3.0",
1110
"constructs>=10.4,<11.0",
1211
"cdk_remote_stack>=2.1,<3.0",
13-
"aws-cdk-lambda-layer-kubectl-v36>=2.0.0,<3.0",
12+
# aws-cdk-lib and aws-cdk-lambda-layer-kubectl-v* must be pinned to an exact version
13+
# so that dependabot will change the constraint here as well as the lockfile.
14+
# Downstream projects like eks-platform-cdk only use this constraint information,
15+
# they don't use the lockfile in this project at all. Since the two lambda layers
16+
# used in the EKS handlers are being instantiated in the downstream projects, the version
17+
# locked by those projects is the one that matters.
18+
"aws-cdk-lib==2.264.0",
19+
"aws-cdk-lambda-layer-kubectl-v36==2.0.0",
1420
]
1521

1622
[project.urls]

uv.lock

Lines changed: 12 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)