chore/Update the billing section

The billing information is mandatory for energy suppliers to provide,
but there could be a chance where we don't get any/all of the data
required.  Therefore we are going to adjust the section to render "N/A"
if the data is missing; as confirmed by Emily

Author: KPobeeNorris

app/components/csr_table/billing_and_metering_scores_component.rb

@@ -25,22 +25,26 @@ def descriptions
     def bills_accuracy_smart
       {
         term: content_tag(:p, "Bills accuracy (smart meters) "),
-        description: content_tag(:p, "#{supplier.bills_accuracy_smart}%")
+        description: content_tag(:p, description_content(supplier.bills_accuracy_smart))
       }
     end
 
     def bills_accuracy_traditional
       {
         term: content_tag(:p, "Bills accuracy (traditional meters)"),
-        description: content_tag(:p, "#{supplier.bills_accuracy_traditional}%")
+        description: content_tag(:p, description_content(supplier.bills_accuracy_traditional))
       }
     end
 
     def smart_operating
       {
         term: content_tag(:p, "Smart meters working correctly"),
-        description: content_tag(:p, "#{supplier.smart_operating}%")
+        description: content_tag(:p, description_content(supplier.smart_operating))
       }
     end
+
+    def description_content(supplier_field)
+      supplier_field.present? ? "#{supplier_field}%" : "N/A"
+    end
   end
 end

spec/components/csr_table/billing_and_metering_scores_component_spec.rb

@@ -14,11 +14,20 @@
   it { is_expected.to have_text "Billing and metering" }
 
   it { is_expected.to have_text "Bills accuracy (smart meters)" }
-  it { is_expected.to have_text "98.3%" }
   it { is_expected.to have_text "Bills accuracy (traditional meters)" }
-  it { is_expected.to have_text "82.9%" }
   it { is_expected.to have_text "Smart meters working correctly" }
-  it { is_expected.to have_text "91.7%" }
+
+  context "when there is billing data" do
+    it { is_expected.to have_text "98.3%" }
+    it { is_expected.to have_text "82.9%" }
+    it { is_expected.to have_text "91.7%" }
+  end
+
+  context "when there is no billing data" do
+    let(:supplier) { build(:supplier, :no_billing_data) }
+
+    it { is_expected.to have_text "N/A", count: 3 }
+  end
 
   context "when there is no supplier" do
     let(:supplier) { nil }

spec/factories/supplier.rb

@@ -12,9 +12,6 @@
     guarantee_rating { 3 }
     overall_rating { 4.8 }
     bill_accuracy_and_metering_rating { 4.8 }
-    bills_accuracy_smart { 98.3 }
-    bills_accuracy_traditional { 82.9 }
-    smart_operating { 91.7 }
     contact_info { { json: JSON.parse(File.read("spec/fixtures/contact_info.json")) } }
     billing_info { { json: JSON.parse(File.read("spec/fixtures/billing_info.json")) } }
     opening_hours { { json: JSON.parse(File.read("spec/fixtures/opening_hours.json")) } }
@@ -30,6 +27,15 @@
       contact_email { 89 }
       contact_social_media { "01:15:00" }
       guarantee_list { { json: JSON.parse(File.read("spec/fixtures/guarantee_list.json")) } }
+      bills_accuracy_smart { 98.3 }
+      bills_accuracy_traditional { 82.9 }
+      smart_operating { 91.7 }
+    end
+
+    trait :no_billing_data do
+      bills_accuracy_smart { nil }
+      bills_accuracy_traditional { nil }
+      smart_operating { nil }
     end
 
     trait :both_guarantee_schemes do
@@ -99,6 +105,10 @@
       data factory: %i[supplier_data ranked]
     end
 
+    trait(:no_billing_data) do
+      data factory: %i[supplier_data no_billing_data]
+    end
+
     trait(:no_guarantee_schemes) do
       data factory: %i[supplier_data no_guarantee_schemes]
     end