Skip to content

Commit 6989947

Browse files
authored
Merge pull request #613 from citizensadvice/chore/upgrade-design-system-to-v8
chore: upgrade design system to v8.1.0
2 parents 613dbd5 + 2adab5e commit 6989947

5 files changed

Lines changed: 28 additions & 33 deletions

File tree

Gemfile

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,20 @@ gem "meta-tags", "~> 2.22"
3434
# Reduces boot times through caching; required in config/boot.rb
3535
gem "bootsnap", require: false
3636

37+
# Use the Citizens Advice Design System
38+
# Pinned version, should match @citizensadvice/design-system in package.json
3739
gem "citizens_advice_components",
3840
github: "citizensadvice/design-system",
39-
tag: "v6.4.2",
41+
tag: "v8.1.0",
4042
glob: "engine/*.gemspec"
4143

42-
gem "citizens_advice_form_builder",
43-
github: "citizensadvice/rails-form-builder",
44-
tag: "v0.2.0"
45-
44+
# The citizens_advice_components gem uses view component but we also use this to write
45+
# our app components so explicitly name it as an application dependency.
4646
gem "view_component", "~> 3.23"
4747

48+
# Multi-step forms. Used alongside the design system form builder
49+
gem "wizard_steps", "~> 0.1.4"
50+
4851
gem "datadog"
4952
gem "factory_bot_rails"
5053
gem "faraday"
@@ -93,5 +96,3 @@ group :test do
9396
gem "selenium-webdriver"
9497
gem "webdrivers"
9598
end
96-
97-
gem "wizard_steps", "~> 0.1.4"

Gemfile.lock

Lines changed: 14 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -21,27 +21,19 @@ GIT
2121

2222
GIT
2323
remote: https://github.com/citizensadvice/design-system.git
24-
revision: efe786cca5823edc4934031cec494d79c5b62082
25-
tag: v6.4.2
24+
revision: c3cb623bf7eeac13c5573d7594032bc10f611021
25+
tag: v8.1.0
2626
glob: engine/*.gemspec
2727
specs:
28-
citizens_advice_components (6.4.2)
29-
actionpack (>= 7.0.0, < 9.0)
30-
railties (>= 7.0.0, < 9.0)
31-
view_component (>= 2.0.0, < 4.0)
32-
33-
GIT
34-
remote: https://github.com/citizensadvice/rails-form-builder.git
35-
revision: c55469691bd453f665a299d592e1ef263024e454
36-
tag: v0.2.0
37-
specs:
38-
citizens_advice_form_builder (0.2.0)
39-
actionpack (>= 6.1.0, < 8.0)
40-
actionview (>= 6.1.0, < 8.0)
41-
activemodel (>= 6.1.0, < 8.0)
42-
activerecord (>= 6.1.0, < 8.0)
43-
activesupport (>= 6.1.0, < 8.0)
44-
citizens_advice_components
28+
citizens_advice_components (8.1.0)
29+
actionpack (>= 7.1.0, < 9.0)
30+
actionview (>= 7.1.0, < 9.0)
31+
activemodel (>= 7.1.0, < 9.0)
32+
activerecord (>= 7.1.0, < 9.0)
33+
activesupport (>= 7.1.0, < 9.0)
34+
rails-i18n (>= 7.0.10)
35+
railties (>= 7.1.0, < 9.0)
36+
view_component (>= 2.0.0, < 5.0)
4537

4638
GEM
4739
remote: https://rubygems.org/
@@ -381,6 +373,9 @@ GEM
381373
rails-html-sanitizer (1.6.2)
382374
loofah (~> 2.21)
383375
nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0)
376+
rails-i18n (7.0.10)
377+
i18n (>= 0.7, < 2)
378+
railties (>= 6.0.0, < 8)
384379
rails_semantic_logger (4.18.0)
385380
rack
386381
railties (>= 5.1)
@@ -539,7 +534,6 @@ DEPENDENCIES
539534
capybara_accessible_selectors!
540535
citizens-advice-style!
541536
citizens_advice_components!
542-
citizens_advice_form_builder!
543537
climate_control
544538
cssbundling-rails
545539
cucumber-rails

app/controllers/appliance_calculator/daily_usage_creation/steps_controller.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ class StepsController < ApplicationController
77

88
self.wizard_class = ::DailyUsageCreation::Wizard
99

10-
default_form_builder ::CitizensAdviceFormBuilder::FormBuilder
10+
default_form_builder ::CitizensAdviceComponents::FormBuilder
1111

1212
class MissingApplianceError < StandardError; end
1313

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "app",
33
"private": "true",
44
"dependencies": {
5-
"@citizensadvice/design-system": "^6.4.2",
5+
"@citizensadvice/design-system": "^8.1.0",
66
"@datadog/browser-logs": "^6.17.0",
77
"esbuild": "^0.25.8",
88
"eslint-plugin-import": "^2.32.0",

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@
2828
chalk "^2.0.0"
2929
js-tokens "^4.0.0"
3030

31-
"@citizensadvice/design-system@^6.4.2":
32-
version "6.4.2"
33-
resolved "https://registry.yarnpkg.com/@citizensadvice/design-system/-/design-system-6.4.2.tgz#0f31a577d734ce98f0d190dc5740324d1f8d749a"
34-
integrity sha512-NSZALoFSp/XwAcTCHSlOUqrHnxoyPDxHD8fejdVRZInx+2njcrW5VCUZL9Sc8fmUjz3FBnyy8v+O2DaoWtnKLw==
31+
"@citizensadvice/design-system@^8.1.0":
32+
version "8.1.0"
33+
resolved "https://registry.yarnpkg.com/@citizensadvice/design-system/-/design-system-8.1.0.tgz#32ae00c163da914f656e955cc87e6ec96cb90135"
34+
integrity sha512-DUJulHNdhSbOHdso6fSg6vjROcKuXf7OC0QSm/kZnC1dMA+cOkFszi6YIVbYlK8zFl4ufOQb/GA+EU2hrBJXmA==
3535

3636
"@csstools/css-parser-algorithms@^3.0.5":
3737
version "3.0.5"

0 commit comments

Comments
 (0)