fix/contact sync/async data check

The contact sync/async fields have been newly added to Contentful which
means that at present if there isn't a value then `nil` is returned.
However, if someone manually deletes the value in Contentful, or the
value is removed from the spreadsheet and imported via the CSR upload
tool then `"'` is returned.  The current code is written as `return
unless supplier.some_field` which is ok at present as the field is
either present or `nil`, but we need to account for the fact we will get
empty strings back in the future and therefore need to update the check
to be `supplier.some_field.blank?` to ensure pages won't crash

I've updated a couple of the test supplier factory fields to include
empty strings to make sure that any future code changes that could break
this behaviour will be caught

Author: KPobeeNorris

app/components/csr_table/contact_waiting_time_scores_component.rb

@@ -72,7 +72,7 @@ def format_sync_output(time_str)
     end
 
     def webchat_sync
-      return unless supplier.contact_webchat_sync
+      return if supplier.contact_webchat_sync.blank?
 
       {
         term: content_tag(:p, "Average Webchat response time"),
@@ -81,7 +81,7 @@ def webchat_sync
     end
 
     def webchat_async
-      return unless supplier.contact_webchat_async
+      return if supplier.contact_webchat_async.blank?
 
       {
         term: content_tag(:p, "Webchat messages responded to within 2 days"),
@@ -90,7 +90,7 @@ def webchat_async
     end
 
     def whatsapp_sync
-      return unless supplier.contact_whatsapp_sync
+      return if supplier.contact_whatsapp_sync.blank?
 
       {
         term: content_tag(:p, "Average Whatsapp response time"),
@@ -99,7 +99,7 @@ def whatsapp_sync
     end
 
     def whatsapp_async
-      return unless supplier.contact_whatsapp_async
+      return if supplier.contact_whatsapp_async.blank?
 
       {
         term: content_tag(:p, "Whatsapp messages responded to within 2 days"),
@@ -108,7 +108,7 @@ def whatsapp_async
     end
 
     def sms_sync
-      return unless supplier.contact_sms_sync
+      return if supplier.contact_sms_sync.blank?
 
       {
         term: content_tag(:p, "Average SMS response time"),
@@ -117,7 +117,7 @@ def sms_sync
     end
 
     def sms_async
-      return unless supplier.contact_sms_async
+      return if supplier.contact_sms_async.blank?
 
       {
         term: content_tag(:p, "SMS messages responded to within 2 days"),
@@ -126,7 +126,7 @@ def sms_async
     end
 
     def in_app_sync
-      return unless supplier.contact_in_app_sync
+      return if supplier.contact_in_app_sync.blank?
 
       {
         term: content_tag(:p, "Average response time using the supplier's app"),
@@ -135,7 +135,7 @@ def in_app_sync
     end
 
     def in_app_async
-      return unless supplier.contact_in_app_async
+      return if supplier.contact_in_app_async.blank?
 
       {
         term: content_tag(:p, "Messages responded to within 2 days using the supplier's app"),
@@ -144,7 +144,7 @@ def in_app_async
     end
 
     def portal_sync
-      return unless supplier.contact_portal_sync
+      return if supplier.contact_portal_sync.blank?
 
       {
         term: content_tag(:p, "Average response time using a customer account portal"),
@@ -153,7 +153,7 @@ def portal_sync
     end
 
     def portal_async
-      return unless supplier.contact_portal_async
+      return if supplier.contact_portal_async.blank?
 
       {
         term: content_tag(:p, "Messages responded to within 2 days using a customer account portal"),

spec/factories/supplier.rb

@@ -64,13 +64,13 @@
       contact_time { "00:03:27" }
       contact_email { 89 }
       contact_webchat_sync { nil }
-      contact_whatsapp_sync { nil }
-      contact_sms_sync { nil }
+      contact_whatsapp_sync { "" }
+      contact_sms_sync { "" }
       contact_in_app_sync { nil }
       contact_portal_sync { nil }
       contact_webchat_async { nil }
-      contact_whatsapp_async { nil }
-      contact_sms_async { nil }
+      contact_whatsapp_async { "" }
+      contact_sms_async { "" }
       contact_in_app_async { nil }
       contact_portal_async { nil }
     end