Skip to content

Commit 876b7d4

Browse files
authored
Merge pull request #876 from citizensadvice/update-haml
Update haml, haml-rails & haml-lint
2 parents 0a14c5c + d9a7ffa commit 876b7d4

21 files changed

Lines changed: 55 additions & 47 deletions

.haml-lint.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,7 @@ linters:
44

55
ClassesBeforeIds:
66
EnforcedStyle: "id"
7+
8+
RuboCop:
9+
ignored_cops:
10+
- Style/IfUnlessModifier

Gemfile.lock

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -235,20 +235,21 @@ GEM
235235
graphql-client (0.26.0)
236236
activesupport (>= 3.0)
237237
graphql (>= 1.13.0)
238-
haml (6.3.0)
238+
haml (7.3.0)
239+
prism (>= 1.1.0)
239240
temple (>= 0.8.2)
240241
thor
241242
tilt
242243
haml-lint (0.999.999)
243244
haml_lint
244-
haml-rails (3.0.0)
245+
haml-rails (3.1.0)
245246
actionpack (>= 5.1)
246247
activesupport (>= 5.1)
247248
haml (>= 4.0.6)
248249
railties (>= 5.1)
249-
haml_lint (0.60.0)
250+
haml_lint (0.77.0)
250251
haml (>= 5.0)
251-
parallel (~> 1.10)
252+
parallel (>= 1.10)
252253
rainbow
253254
rubocop (>= 1.0)
254255
sysexits (~> 1.1)
@@ -334,7 +335,7 @@ GEM
334335
racc (~> 1.4)
335336
nokogiri (1.19.4-x86_64-linux-musl)
336337
racc (~> 1.4)
337-
parallel (1.28.0)
338+
parallel (2.1.0)
338339
parser (3.3.12.0)
339340
ast (~> 2.4.1)
340341
racc
@@ -497,9 +498,9 @@ GEM
497498
ffi (~> 1.1)
498499
memoist3 (~> 1.0.0)
499500
sysexits (1.2.0)
500-
temple (0.10.4)
501+
temple (0.10.6)
501502
thor (1.5.0)
502-
tilt (2.6.1)
503+
tilt (2.8.0)
503504
timeout (0.6.1)
504505
tomlrb (2.0.3)
505506
tsort (0.2.0)
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
%form{ action: appliance_calculator_clear_path, method: "GET" }
22
= render CitizensAdviceComponents::Button.new(variant: :tertiary, type: :submit, attributes: attrs) do
33
Clear list
4-

app/components/appliance_calculator/last_added_appliance_component.html.haml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
= render CitizensAdviceComponents::SuccessMessage.new(message: message)
33
.last-added-appliance__dismiss-wrapper
44
%button{ dismiss_button_attrs }
5-
= render CitizensAdviceComponents::Icons::Close.new
5+
= render CitizensAdviceComponents::Icons::Close.new

app/components/appliance_calculator/usages_table_component.html.haml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,3 @@
55

66
.cads-prose
77
%p Calculated using a rate of #{formatted_unit_rate} p/kWh.
8-
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
%svg.star.star--half{ width: "17", height: "14", viewBox: "0 0 17 15", fill: "none", xmlns: "http://www.w3.org/2000/svg", "aria-hidden": "true" }
2-
%use{ href:"#halfStar" }
2+
%use{ href: "#halfStar" }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
%svg.star.star--half{ width: "17", height: "14", viewBox: "0 0 17 15", fill: "none", xmlns: "http://www.w3.org/2000/svg", "aria-hidden": "true" }
2-
%use{ href:"#highlightedHalfStar" }
2+
%use{ href: "#highlightedHalfStar" }

app/components/csr_table/unranked_suppliers/details_component.html.haml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
.unranked-supplier__title{ "data-testid": "unranked-supplier-details-#{supplier.name.parameterize}" }
33
= title
44
- if Feature.enabled? "FF_SMALL_SUPPLIER_STARS"
5-
-if whitelabelled?
5+
- if whitelabelled?
66
%p
77
= whitelabel_supplier_link
8-
-else
8+
- else
99
= render CsrTable::UnrankedSuppliers::StarsSummaryComponent.new(supplier)
1010

1111
= render CsrTable::DescriptionListComponent.new do |c|

app/views/appliance_calculator/daily_usage_creation/_cost_estimation.html.haml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,3 @@
1616

1717
%p
1818
The actual usage can also depend on things like your appliance’s size or the type of technology it uses.
19-

app/views/appliance_calculator/daily_usage_creation/steps/_cyclical_usage.html.haml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@
1313
= current_step.cycle_frequency_error
1414
.frequency-inputs
1515
.frequency-inputs__item
16-
= form.cads_text_field :cycles, label: "Cycles", width: :two_chars, required: true, options: { additional_attributes: { "inputmode": "numeric", id: "daily_usage_creation_steps_time_usage_base-input" } }
16+
= form.cads_text_field :cycles, label: "Cycles", width: :two_chars, required: true, options: { additional_attributes: { inputmode: "numeric", id: "daily_usage_creation_steps_time_usage_base-input" } }
1717
.frequency-inputs__item
18-
= form.cads_collection_select :frequency, label: "Frequency", required: true, collection: current_step.frequency_options, text_method: :text, value_method: :value
18+
= form.cads_collection_select :frequency, label: "Frequency", required: true, collection: current_step.frequency_options, text_method: :text, value_method: :value

0 commit comments

Comments
 (0)