Skip to content

Commit fac5503

Browse files
authored
Merge pull request #630 from citizensadvice/fundraising-regulator-logo
CP-606: add Fundraing Regulator logo to the footer
2 parents 8920e33 + 15d8ee6 commit fac5503

8 files changed

Lines changed: 26 additions & 10 deletions

File tree

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ gem "bootsnap", require: false
3838
# Pinned version, should match @citizensadvice/design-system in package.json
3939
gem "citizens_advice_components",
4040
github: "citizensadvice/design-system",
41-
tag: "v8.1.0",
41+
tag: "v8.3.0",
4242
glob: "engine/*.gemspec"
4343

4444
gem "citizens_advice_cookie_preferences",

Gemfile.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@ GIT
3131

3232
GIT
3333
remote: https://github.com/citizensadvice/design-system.git
34-
revision: c3cb623bf7eeac13c5573d7594032bc10f611021
35-
tag: v8.1.0
34+
revision: deed9ed919cc1452c8e440e6cf45c1f3a1469bd8
35+
tag: v8.3.0
3636
glob: engine/*.gemspec
3737
specs:
38-
citizens_advice_components (8.1.0)
38+
citizens_advice_components (8.3.0)
3939
actionpack (>= 7.1.0, < 9.0)
4040
actionview (>= 7.1.0, < 9.0)
4141
activemodel (>= 7.1.0, < 9.0)

app/components/footer_component.rb

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ def call
1717
title: @feedback_title,
1818
new_tab: true)
1919
c.with_columns(@columns)
20+
c.with_additional_logo { fundraising_regulator_logo }
2021
end
2122
end
2223

@@ -27,4 +28,12 @@ def research_uri
2728

2829
URI::HTTPS.build(host: "www.research.net", path: "/r/#{@feedback_survey_id}", query: hash.to_query)
2930
end
31+
32+
def fundraising_regulator_logo
33+
image_tag fundraising_regulator_logo_url, alt: "Fundraising Regulator registered"
34+
end
35+
36+
def fundraising_regulator_logo_url
37+
"https://www.fundraisingregulator.org.uk/fr-badge/6d8352f2-d995-4eea-bb60-a28c2dc8d842/en/black"
38+
end
3039
end

config/initializers/content_security_policy.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,9 @@
6868

6969
# DataDog JS error logging
7070
merge_into[:connect_src, "https://browser-intake-datadoghq.eu"]
71+
72+
# Fundraising Regulator logo (we have to use the third party hosted one to demonstrate the validation)
73+
merge_into[:img_src, "https://www.fundraisingregulator.org.uk"]
7174
end
7275
# rubocop:enable Metrics/BlockLength
7376

docs/getting-started.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,4 +56,4 @@ You can run the application along with asset compilation using the following dev
5656
./bin/dev
5757
```
5858

59-
If all is working you should be able to access the application at `http://localhost:3000/`
59+
If all is working you should be able to access the application at `http://localhost:3300/`

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "app",
33
"private": "true",
44
"dependencies": {
5-
"@citizensadvice/design-system": "^8.1.0",
5+
"@citizensadvice/design-system": "8.3.0",
66
"@datadog/browser-logs": "^6.18.1",
77
"esbuild": "^0.25.9",
88
"eslint-plugin-import": "^2.32.0",

spec/components/footer_component_spec.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,8 @@
4141
describe "footer columns" do
4242
it { is_expected.to have_css "nav ul", count: 2 }
4343
end
44+
45+
describe "Fundraising Regulator logo" do
46+
it { is_expected.to have_css 'img[src^="https://www.fundraisingregulator.org.uk"]' }
47+
end
4448
end

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@
2828
chalk "^2.0.0"
2929
js-tokens "^4.0.0"
3030

31-
"@citizensadvice/design-system@^8.1.0":
32-
version "8.1.0"
33-
resolved "https://registry.yarnpkg.com/@citizensadvice/design-system/-/design-system-8.1.0.tgz#32ae00c163da914f656e955cc87e6ec96cb90135"
34-
integrity sha512-DUJulHNdhSbOHdso6fSg6vjROcKuXf7OC0QSm/kZnC1dMA+cOkFszi6YIVbYlK8zFl4ufOQb/GA+EU2hrBJXmA==
31+
"@citizensadvice/design-system@8.3.0":
32+
version "8.3.0"
33+
resolved "https://registry.yarnpkg.com/@citizensadvice/design-system/-/design-system-8.3.0.tgz#6203d39db9bf784da7dd1ea6691c0aa014cd48f5"
34+
integrity sha512-1BMF+5yNKFo8e9Mag6SfVRwHboFv/RJBH0Ry6rhXHSabxL9CiG+ePdZ/aE2eU08MhOB7vZQBYmT7hJ9IVBhPnA==
3535

3636
"@csstools/css-parser-algorithms@^3.0.5":
3737
version "3.0.5"

0 commit comments

Comments
 (0)