Skip to content

Commit 70e1bf2

Browse files
committed
fix: clean up wasm and built ts
1 parent d4fb0d4 commit 70e1bf2

File tree

6 files changed

+4
-32
lines changed

6 files changed

+4
-32
lines changed

src/rust/fcb_core/src/http_reader/mock_http_range_client.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ impl HttpFcbReader<MockHttpRangeClient> {
1717
HttpFcbReader<MockHttpRangeClient>,
1818
Arc<RwLock<RequestStats>>,
1919
)> {
20-
trace!("starting: opening http reader, reading header");
21-
2220
let stats = Arc::new(RwLock::new(RequestStats::new()));
2321
let http_client = MockHttpRangeClient::new(path, stats.clone());
2422
let client = http_range_client::AsyncBufferedHttpRangeClient::with(http_client, path);

src/rust/fcb_core/src/http_reader/mod.rs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ pub struct AsyncFeatureIter<T: AsyncHttpRangeClient + Send + Sync> {
6262

6363
impl HttpFcbReader<reqwest::Client> {
6464
pub async fn open(url: &str) -> Result<HttpFcbReader<reqwest::Client>> {
65-
trace!("starting: opening http reader, reading header");
6665
let client = BufferedHttpRangeClient::new(url);
6766
Self::_open(client).await
6867
}
@@ -121,7 +120,6 @@ impl<T: AsyncHttpRangeClient + Send + Sync> HttpFcbReader<T> {
121120
// verify flatbuffer
122121
let _header = size_prefixed_root_as_header(&header_buf)?;
123122

124-
trace!("completed: opening http reader");
125123
Ok(HttpFcbReader {
126124
client,
127125
fbs: FcbBuffer {
@@ -191,7 +189,6 @@ impl<T: AsyncHttpRangeClient + Send + Sync> HttpFcbReader<T> {
191189
}
192190
/// Select features within a bounding box.
193191
pub async fn select_query(mut self, query: Query) -> Result<AsyncFeatureIter<T>> {
194-
trace!("starting: select_bbox, traversing index");
195192
// Read R-Tree index and build filter for features within bbox
196193
let header = self.fbs.header();
197194
if header.index_node_size() == 0 || header.features_count() == 0 {
@@ -222,7 +219,6 @@ impl<T: AsyncHttpRangeClient + Send + Sync> HttpFcbReader<T> {
222219
let count = list.len();
223220
let feature_batches = FeatureBatch::make_batches(list, combine_request_threshold).await?;
224221
let selection = FeatureSelection::SelectBbox(SelectBbox { feature_batches });
225-
trace!("completed: select_bbox");
226222
Ok(AsyncFeatureIter {
227223
client: self.client,
228224
fbs: self.fbs,
@@ -234,7 +230,6 @@ impl<T: AsyncHttpRangeClient + Send + Sync> HttpFcbReader<T> {
234230
/// This method uses the attribute index section to find matching feature offsets.
235231
/// It then groups (batches) the remote feature ranges in order to reduce IO overhead.
236232
pub async fn select_attr_query(mut self, query: &AttrQuery) -> Result<AsyncFeatureIter<T>> {
237-
trace!("starting: select_attr_query via http reader");
238233
let header = self.fbs.header();
239234
let header_len = self.header_len();
240235
// Assume the header provides rtree and attribute index sizes.
@@ -291,11 +286,6 @@ impl<T: AsyncHttpRangeClient + Send + Sync> HttpFcbReader<T> {
291286
})
292287
.collect();
293288

294-
trace!(
295-
"completed: select_attr_query via http reader, matched features: {}",
296-
count
297-
);
298-
299289
println!("http_ranges: {:?}", http_ranges);
300290
Ok(AsyncFeatureIter {
301291
client: self.client,

src/rust/wasm/src/lib.rs

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ mod wasm {
99

1010
use fcb_core::{size_prefixed_root_as_header, Header, Operator};
1111
use js_sys::Array;
12+
1213
use log::Level;
13-
use log::trace;
1414
use serde_wasm_bindgen::to_value;
1515
use wasm_bindgen::prelude::*;
1616

@@ -74,13 +74,12 @@ mod wasm {
7474
pub async fn new(url: String) -> Result<HttpFcbReader, JsValue> {
7575
// Only initialize the logger once
7676
if !LOGGER_INITIALIZED.load(Ordering::SeqCst)
77-
&& console_log::init_with_level(Level::Trace).is_ok()
77+
&& console_log::init_with_level(Level::Info).is_ok()
7878
{
7979
LOGGER_INITIALIZED.store(true, Ordering::SeqCst);
8080
log::info!("Logger initialized successfully.");
8181
}
8282

83-
trace!("starting: opening http reader, reading header");
8483
let client = WasmHttpClient::new(&url);
8584

8685
Self::_open(client).await
@@ -240,7 +239,6 @@ mod wasm {
240239
mut self,
241240
query: &WasmSpatialQuery,
242241
) -> Result<AsyncFeatureIter, JsValue> {
243-
trace!("starting: select_spatial, traversing index");
244242
// Read R-Tree index and build filter for features within bbox
245243
let header = self.fbs.header();
246244
if header.index_node_size() == 0 || header.features_count() == 0 {
@@ -278,7 +276,6 @@ mod wasm {
278276
.await
279277
.map_err(|e| JsValue::from_str(&e.to_string()))?;
280278
let selection = FeatureSelection::SelectSpatial(SelectSpatial { feature_batches });
281-
trace!("completed: select_spatial");
282279
Ok(AsyncFeatureIter {
283280
client: self.client,
284281
fbs: self.fbs,
@@ -292,7 +289,6 @@ mod wasm {
292289
mut self,
293290
query: &WasmAttrQuery,
294291
) -> Result<AsyncFeatureIter, JsValue> {
295-
trace!("starting: select_attr_query via http reader");
296292
let header = self.fbs.header();
297293
let header_len = self.header_len();
298294
// Assume the header provides rtree and attribute index sizes.
@@ -354,10 +350,6 @@ mod wasm {
354350
})
355351
.collect();
356352

357-
trace!(
358-
"completed: select_attr_query via http reader, matched features: {}",
359-
count
360-
);
361353
Ok(AsyncFeatureIter {
362354
client: self.client,
363355
fbs: self.fbs,
@@ -693,16 +685,8 @@ mod wasm {
693685

694686
let wasted_bytes = search_result_item.range.start() - prev_end;
695687
if wasted_bytes < combine_request_threshold {
696-
if wasted_bytes == 0 {
697-
trace!("adjacent feature");
698-
} else {
699-
trace!("wasting {wasted_bytes} to avoid an extra request");
700-
}
701688
latest_batch.push_back(search_result_item.range)
702689
} else {
703-
trace!(
704-
"creating a new request for batch rather than wasting {wasted_bytes} bytes"
705-
);
706690
let mut new_batch = VecDeque::new();
707691
new_batch.push_back(search_result_item.range);
708692
batched_ranges.push(new_batch);

src/ts/fcb_wasm.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -960,7 +960,7 @@ function __wbg_get_imports() {
960960
const ret = false;
961961
return ret;
962962
};
963-
imports.wbg.__wbindgen_closure_wrapper1230 = function(arg0, arg1, arg2) {
963+
imports.wbg.__wbindgen_closure_wrapper1228 = function(arg0, arg1, arg2) {
964964
const ret = makeMutClosure(arg0, arg1, 328, __wbg_adapter_52);
965965
return ret;
966966
};

src/ts/fcb_wasm_bg.wasm

-1.54 KB
Binary file not shown.

src/ts/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@cityjson/flatcitybuf",
33
"type": "module",
4-
"version": "0.1.1",
4+
"version": "0.1.2",
55
"description": "FlatCityBuf is a library for reading and writing CityJSON with FlatBuffers.",
66
"author": {
77
"name": "Hidemichi Baba",

0 commit comments

Comments
 (0)