Skip to content

Extract shared mailing report columns and logic into CRM_Report_Form_Mailing_Base#36321

Merged
mlutfy merged 1 commit into
civicrm:masterfrom
colemanw:mailing-report-base
Jul 25, 2026
Merged

Extract shared mailing report columns and logic into CRM_Report_Form_Mailing_Base#36321
mlutfy merged 1 commit into
civicrm:masterfrom
colemanw:mailing-report-base

Conversation

@colemanw

@colemanw colemanw commented Jul 24, 2026

Copy link
Copy Markdown
Member

Overview

Reduces copy/paste code redundancy in mailing report forms.

Before

Mailing report forms were built with copy & paste.

After

Less so.

Technical Details

Extract duplicated mailing report columns, filters, and SQL logic from CiviMail report form classes (Detail, Bounce, Clicks, Opened) into an abstract base class CRM_Report_Form_Mailing_Base.

@civibot

civibot Bot commented Jul 24, 2026

Copy link
Copy Markdown

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
PR commands & links...
  • /rebase <branch-name> will rebase your branch and change the base of the PR.
  • /squash will combine all commits (keeping only the first commit messsage).
  • /port <branch-name> will create a copy of this PR against a different branch.
  • /lintroll will automatically fix linting errors, amending commits as needed.
  • retest this please will rerun the tests and rebuild the demo site.
  • 📖 Review standards
  • 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

@civibot civibot Bot added the master label Jul 24, 2026
@colemanw
colemanw force-pushed the mailing-report-base branch 2 times, most recently from fc947b6 to 4909e2d Compare July 24, 2026 15:28
…ing_Base

Reduces copy/paste redundancy in mailing report forms
@colemanw
colemanw force-pushed the mailing-report-base branch from 4909e2d to a4c36c5 Compare July 24, 2026 15:38
@mlutfy
mlutfy merged commit fca0151 into civicrm:master Jul 25, 2026
1 check passed
@mlutfy

mlutfy commented Jul 25, 2026

Copy link
Copy Markdown
Member

Merging based on a quick r-run (but demo site does not have mailing data), some code review, and my appreciation for the reduction of copy-pasted code.

@colemanw
colemanw deleted the mailing-report-base branch July 25, 2026 15:50
@colemanw

Copy link
Copy Markdown
Member Author

Thanks @mlutfy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants