Extract shared mailing report columns and logic into CRM_Report_Form_Mailing_Base#36321
Merged
Merged
Conversation
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
PR commands & links...
|
colemanw
force-pushed
the
mailing-report-base
branch
2 times, most recently
from
July 24, 2026 15:28
fc947b6 to
4909e2d
Compare
…ing_Base Reduces copy/paste redundancy in mailing report forms
colemanw
force-pushed
the
mailing-report-base
branch
from
July 24, 2026 15:38
4909e2d to
a4c36c5
Compare
Member
|
Merging based on a quick |
Member
Author
|
Thanks @mlutfy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Reduces copy/paste code redundancy in mailing report forms.
Before
Mailing report forms were built with copy & paste.
After
Less so.
Technical Details
Extract duplicated mailing report columns, filters, and SQL logic from CiviMail report form classes (
Detail,Bounce,Clicks,Opened) into an abstract base classCRM_Report_Form_Mailing_Base.