Skip to content

Commit 40173ff

Browse files
authored
Merge pull request #28 from civitaspo/rmUselessTargetFileInfoBuild
Remove tautologised TargetFileInfo Build code
2 parents 2b741d6 + 4d9ecaa commit 40173ff

File tree

1 file changed

+13
-28
lines changed

1 file changed

+13
-28
lines changed

Diff for: src/main/java/org/embulk/input/hdfs/HdfsFileInputPlugin.java

+13-28
Original file line numberDiff line numberDiff line change
@@ -170,36 +170,21 @@ private TargetFileInfoList buildTargetFileInfoList(PluginTask task, List<FileSta
170170
numPartitions = ((status.getLen() - 1) / partitionSizeByOneTask) + 1;
171171
}
172172

173-
if (numPartitions > 1) { // has partitions
174-
for (long i = 0; i < numPartitions; i++) {
175-
long start = status.getLen() * i / numPartitions;
176-
long end = status.getLen() * (i + 1) / numPartitions;
177-
if (start < end) {
178-
TargetFileInfo targetFileInfo = new TargetFileInfo.Builder()
179-
.pathString(status.getPath().toString())
180-
.start(start)
181-
.end(end)
182-
.isDecompressible(isDecompressible(task, conf, status)) // false
183-
.isPartitionable(isPartitionable(task, conf, status)) // true
184-
.numHeaderLines(task.getSkipHeaderLines())
185-
.build();
186-
builder.add(targetFileInfo);
187-
}
173+
for (long i = 0; i < numPartitions; i++) {
174+
long start = status.getLen() * i / numPartitions;
175+
long end = status.getLen() * (i + 1) / numPartitions;
176+
if (start < end) {
177+
TargetFileInfo targetFileInfo = new TargetFileInfo.Builder()
178+
.pathString(status.getPath().toString())
179+
.start(start)
180+
.end(end)
181+
.isDecompressible(isDecompressible(task, conf, status))
182+
.isPartitionable(isPartitionable(task, conf, status))
183+
.numHeaderLines(task.getSkipHeaderLines())
184+
.build();
185+
builder.add(targetFileInfo);
188186
}
189187
}
190-
else {
191-
// has no partition
192-
// the file is compressed or no partition option is selected.
193-
TargetFileInfo targetFileInfo = new TargetFileInfo.Builder()
194-
.pathString(status.getPath().toString())
195-
.start(0L)
196-
.end(status.getLen())
197-
.isDecompressible(isDecompressible(task, conf, status)) // true or false
198-
.isPartitionable(isPartitionable(task, conf, status)) // false
199-
.numHeaderLines(task.getSkipHeaderLines())
200-
.build();
201-
builder.add(targetFileInfo);
202-
}
203188
}
204189
return builder.build();
205190
}

0 commit comments

Comments
 (0)