Skip to content
This repository was archived by the owner on Jan 16, 2023. It is now read-only.

Commit 2fa215e

Browse files
committed
tests: improve tests readability
1 parent 99cda43 commit 2fa215e

File tree

2 files changed

+14
-6
lines changed

2 files changed

+14
-6
lines changed

Sources/Clappr_iOS/Classes/Plugin/Core/MediaControl/QuickSeekMediaControlPlugin.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public class QuickSeekMediaControlPlugin: QuickSeekPlugin {
2424

2525
@objc private func didTap(gestureRecognizer: UITapGestureRecognizer) {
2626
if gestureRecognizer.state == .recognized {
27-
let point = gestureRecognizer.location(in: view)
27+
let point = gestureRecognizer.location(in: mediaControl?.mediaControlView)
2828
if shouldSeek(point: point) {
2929
mediaControl?.hide()
3030
quickSeek(xPosition: point.x)

Tests/Clappr_Tests/Classes/Plugin/Core/MediaControl/QuickSeekMediaControlPluginTests.swift

+13-5
Original file line numberDiff line numberDiff line change
@@ -77,29 +77,36 @@ class QuickSeekMediaControlPluginTests: QuickSpec {
7777
mediaControl.render()
7878
playButton.view.layoutIfNeeded()
7979
mediaControl.view.layoutIfNeeded()
80+
8081
}
8182

8283
context("and it collides with that plugin") {
8384
it("does not seek") {
84-
let shouldSeek = quickSeekPlugin.shouldSeek(point: CGPoint(x: 100, y: 100))
85+
let playButtonCenterInMediaControlCoordinate = playButton.view.convert(playButton.view.center, to: mediaControl.mediaControlView)
86+
87+
let shouldSeek = quickSeekPlugin.shouldSeek(point: playButtonCenterInMediaControlCoordinate)
8588

8689
expect(shouldSeek).to(beFalse())
8790
}
8891
}
8992

9093
context("and it does not collide with that plugin") {
9194
it("does seek") {
92-
let shouldSeek = quickSeekPlugin.shouldSeek(point: CGPoint(x: 260, y: 100))
95+
let pointOutsidePlayButton = CGPoint(x: playButton.view.frame.width + 1, y: playButton.view.frame.height + 1)
96+
let outsidePointInMediaControlCoordinate = playButton.view.convert(pointOutsidePlayButton, to: mediaControl.mediaControlView)
97+
98+
let shouldSeek = quickSeekPlugin.shouldSeek(point: outsidePointInMediaControlCoordinate)
9399

94100
expect(shouldSeek).to(beTrue())
95101
}
96102
}
97103

98104
context("and that plugin is not visible") {
99105
it("does seek") {
106+
let playButtonCenterInMediaControlCoordinate = playButton.view.convert(playButton.view.center, to: mediaControl.mediaControlView)
100107
playButton.view.alpha = 0.0
101108

102-
let shouldSeek = quickSeekPlugin.shouldSeek(point: CGPoint(x: 100, y: 100))
109+
let shouldSeek = quickSeekPlugin.shouldSeek(point: playButtonCenterInMediaControlCoordinate)
103110

104111
expect(shouldSeek).to(beTrue())
105112
}
@@ -113,8 +120,9 @@ class QuickSeekMediaControlPluginTests: QuickSpec {
113120
core.render()
114121
overlayPlugin.render()
115122
overlayPlugin.view.layoutIfNeeded()
116-
117-
let shouldSeek = quickSeekPlugin.shouldSeek(point: CGPoint(x: 260, y: 100))
123+
let overlayPluginCenterInMediaControlCoordinate = overlayPlugin.view.convert(overlayPlugin.view.center, to: mediaControl.mediaControlView)
124+
125+
let shouldSeek = quickSeekPlugin.shouldSeek(point: overlayPluginCenterInMediaControlCoordinate)
118126

119127
expect(shouldSeek).to(beTrue())
120128
}

0 commit comments

Comments
 (0)