fix: bundle name may be stripped to empty string (#87)

bundle display names may not contain any ascii characters. In this case, when stripping the characters it may end up blank which causes the request for ensuring app id to fail as it does not accept blank fields.

this uses CFBundleName and has a fallback to the bundle identifier.

Author: bitxeno

crates/plume_types/src/bundle.rs

@@ -168,6 +168,10 @@ impl PlistInfoTrait for Bundle {
         get_plist_string!(self, "CFBundleIdentifier")
     }
 
+    fn get_bundle_name(&self) -> Option<String> {
+        get_plist_string!(self, "CFBundleName")
+    }
+
     fn get_version(&self) -> Option<String> {
         get_plist_string!(self, "CFBundleShortVersionString")
     }

crates/plume_types/src/lib.rs

@@ -60,6 +60,7 @@ pub trait PlistInfoTrait {
     fn get_name(&self) -> Option<String>;
     fn get_executable(&self) -> Option<String>;
     fn get_bundle_identifier(&self) -> Option<String>;
+    fn get_bundle_name(&self) -> Option<String>;
     fn get_version(&self) -> Option<String>;
     fn get_build_version(&self) -> Option<String>;
 }

crates/plume_types/src/package.rs

@@ -166,6 +166,10 @@ impl PlistInfoTrait for Package {
         get_plist_dict_value!(self, "CFBundleIdentifier")
     }
 
+    fn get_bundle_name(&self) -> Option<String> {
+        get_plist_dict_value!(self, "CFBundleName")
+    }
+
     fn get_version(&self) -> Option<String> {
         get_plist_dict_value!(self, "CFBundleShortVersionString")
     }

crates/plume_types/src/signer.rs

@@ -208,9 +208,9 @@ impl Signer {
                     .get_bundle_identifier()
                     .ok_or_else(|| Error::Other("Failed to get bundle identifier.".into()))?;
 
-                session
-                    .qh_ensure_app_id(&team_id, &sub_bundle.get_name().unwrap_or_default(), &id)
-                    .await?;
+                let name = sub_bundle.get_bundle_name().unwrap_or_else(|| id.clone());
+
+                session.qh_ensure_app_id(&team_id, &name, &id).await?;
 
                 let app_id_id = session
                     .qh_get_app_id(&team_id, &id)