feat: windows installer & titlebar icon (#2)

* feat: nsis install scripts

* chore: minor changes to actions

* fix

* add windows icon in titlebar

* oops

* Update installer.nsi

Author: claration

.github/workflows/build.yml

@@ -68,9 +68,6 @@ jobs:
       - name: Install Rust stable
         uses: dtolnay/rust-toolchain@stable
 
-      - name: Setup Windows dependencies
-        run: choco install strawberryperl make --no-progress
-
       - name: Setup Windows MSVC environment
         uses: ilammy/msvc-dev-cmd@v1
 
@@ -80,11 +77,19 @@ jobs:
           cargo fetch --locked || true
           cargo patch-crate --force
           mkdir -p build/out
+          mkdir -p build/nsis
 
       - name: Build & Bundle (Windows)
         run: |
           cargo build --bin ${{ env.BINARY_NAME }} --release
-          cp target/release/${{ env.BINARY_NAME }}.exe build/out
+          cp target/release/${{ env.BINARY_NAME }}.exe build/nsis
+
+      - name: Create NSIS Installer
+        run: |
+          mv package/windows/* build/nsis/
+          choco install nsis.portable
+          makensis build/nsis/installer.nsi
+          mv build/nsis/PlumeInstaller.exe build/out/${{ env.BINARY_NAME }}-setup.exe
 
       - name: Upload Bundles
         uses: actions/upload-artifact@v4

apps/plumeimpactor/src/frame.rs

@@ -21,6 +21,11 @@ use crate::keychain::AccountCredentials;
 use crate::pages::{LoginDialog, DefaultPage, InstallPage, SettingsDialog, WINDOW_SIZE, create_default_page, create_install_page, create_login_dialog, create_settings_dialog};
 use crate::utils::{Device, Package};
 
+#[cfg(target_os = "windows")]
+const INSTALLER_IMAGE_BYTES: &[u8] = include_bytes!("../../../package/windows/icon.rgba");
+#[cfg(target_os = "windows")]
+const INSTALLER_IMAGE_SIZE: u32 = 128;
+
 pub const APP_NAME: &str = concat!(env!("CARGO_PKG_NAME"), " – Version ", env!("CARGO_PKG_VERSION"));
 
 pub struct PlumeFrame {
@@ -44,6 +49,17 @@ impl PlumeFrame {
             .with_style(FrameStyle::CloseBox | FrameStyle::MinimizeBox | FrameStyle::Caption | FrameStyle::SystemMenu)
             .build();
 
+        #[cfg(target_os = "windows")]
+        {
+            let bitmap = Bitmap::from_rgba(
+                INSTALLER_IMAGE_BYTES,
+                INSTALLER_IMAGE_SIZE,
+                INSTALLER_IMAGE_SIZE,
+            ).unwrap();
+
+            frame.set_icon(&bitmap);
+        }
+
         let sizer = BoxSizer::builder(Orientation::Vertical).build();
 
         let top_row = BoxSizer::builder(Orientation::Horizontal).build();

package/windows/icon.rgba

@@ -0,0 +1,87 @@
+;===========================================================
+; Modern NSIS Installer for a Single EXE (64-bit)
+;===========================================================
+
+!define APPNAME "PlumeImpactor"
+!define APPEXE  "plumeimpactor.exe"
+!define COMPANY "Samara"
+
+Name "${APPNAME}"
+BrandingText "${APPNAME} Setup"
+
+OutFile "PlumeInstaller.exe"
+
+RequestExecutionLevel admin
+InstallDir "$PROGRAMFILES64\${APPNAME}"
+InstallDirRegKey HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APPNAME}" "InstallLocation"
+
+;-----------------------------------------------------------
+; Modern UI 2
+;-----------------------------------------------------------
+!include "MUI2.nsh"
+
+!define MUI_ABORTWARNING
+!define MUI_ICON "icon.ico"
+!define MUI_UNICON "icon.ico"
+
+;-----------------------------------------------------------
+; Installer Pages
+;-----------------------------------------------------------
+!insertmacro MUI_PAGE_WELCOME
+!insertmacro MUI_PAGE_DIRECTORY
+!insertmacro MUI_PAGE_INSTFILES
+!insertmacro MUI_PAGE_FINISH
+
+;-----------------------------------------------------------
+; Uninstaller Pages
+;-----------------------------------------------------------
+!insertmacro MUI_UNPAGE_WELCOME
+!insertmacro MUI_UNPAGE_CONFIRM
+!insertmacro MUI_UNPAGE_INSTFILES
+!insertmacro MUI_UNPAGE_FINISH
+
+!insertmacro MUI_LANGUAGE "English"
+
+;===========================================================
+; Installer Section
+;===========================================================
+Section "Install"
+
+    SetOutPath "$INSTDIR"
+    File "${APPEXE}"
+
+    ; Start Menu entries
+    CreateDirectory "$SMPROGRAMS\${APPNAME}"
+    CreateShortcut "$SMPROGRAMS\${APPNAME}\${APPNAME}.lnk" "$INSTDIR\${APPEXE}"
+
+    CreateShortcut "$DESKTOP\${APPNAME}.lnk" "$INSTDIR\${APPEXE}"
+
+    WriteUninstaller "$INSTDIR\Uninstall.exe"
+
+    ; 64-bit registry uninstall entry
+    WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APPNAME}" "DisplayName" "${APPNAME}"
+    WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APPNAME}" "Publisher" "${COMPANY}"
+    WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APPNAME}" "InstallLocation" "$INSTDIR"
+    WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APPNAME}" "UninstallString" "$INSTDIR\Uninstall.exe"
+    WriteRegDWORD HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APPNAME}" "NoModify" 1
+    WriteRegDWORD HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APPNAME}" "NoRepair" 1
+
+SectionEnd
+
+;===========================================================
+; Uninstaller Section
+;===========================================================
+Section "Uninstall"
+
+    Delete "$DESKTOP\${APPNAME}.lnk"
+    Delete "$SMPROGRAMS\${APPNAME}\${APPNAME}.lnk"
+    RMDir  "$SMPROGRAMS\${APPNAME}"
+
+    Delete "$INSTDIR\${APPEXE}"
+    Delete "$INSTDIR\Uninstall.exe"
+
+    RMDir "$INSTDIR"
+
+    DeleteRegKey HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APPNAME}"
+
+SectionEnd