[ExoBundle] fixes quiz migration (#2022)

* [ExoBundle] fixes quiz types migration

* [ExoBundle] fixes answer data migration

Author: Elorfin

plugin/exo/Installation/AdditionalInstaller.php

@@ -8,6 +8,7 @@
 use UJM\ExoBundle\Installation\Updater\Updater060200;
 use UJM\ExoBundle\Installation\Updater\Updater070000;
 use UJM\ExoBundle\Installation\Updater\Updater090000;
+use UJM\ExoBundle\Installation\Updater\Updater090002;
 
 class AdditionalInstaller extends BaseInstaller
 {
@@ -63,5 +64,13 @@ public function postUpdate($currentVersion, $targetVersion)
             $updater->setLogger($this->logger);
             $updater->postUpdate();
         }
+
+        if (version_compare($currentVersion, '9.0.2', '<')) {
+            $updater = new Updater090002(
+                $this->container->get('doctrine.dbal.default_connection')
+            );
+            $updater->setLogger($this->logger);
+            $updater->postUpdate();
+        }
     }
 }

plugin/exo/Installation/Updater/Updater090000.php

@@ -192,11 +192,16 @@ private function updateAnswerData()
                     $newData = array_map(function ($association) use ($propNames, $labels, $proposals) {
                         $associationData = explode(',', $association);
 
-                        $data = new \stdClass();
+                        $data = null;
 
-                        // Convert ids into uuids
-                        $data->{$propNames[0]} = $this->getAnswerPartUuid($associationData[0], $proposals);
-                        $data->{$propNames[1]} = $this->getAnswerPartUuid($associationData[1], $labels);
+                        // The new system only allows complete association in answers
+                        if (!empty($associationData) && 2 === count($associationData)) {
+                            $data = new \stdClass();
+
+                            // Convert ids into uuids
+                            $data->{$propNames[0]} = $this->getAnswerPartUuid($associationData[0], $proposals);
+                            $data->{$propNames[1]} = $this->getAnswerPartUuid($associationData[1], $labels);
+                        }
 
                         return $data;
                     }, $answerData);
@@ -216,10 +221,14 @@ private function updateAnswerData()
                         $pairData = explode(',', $pair);
 
                         // Convert ids into uuids
-                        return [
-                            $this->getAnswerPartUuid($pairData[0], $proposals),
-                            $this->getAnswerPartUuid($pairData[1], $labels),
-                        ];
+                        if (!empty($pairData) && 2 === count($pairData)) {
+                            return [
+                                $this->getAnswerPartUuid($pairData[0], $proposals),
+                                $this->getAnswerPartUuid($pairData[1], $labels),
+                            ];
+                        } else {
+                            return null;
+                        }
                     }, $answerData);
 
                     break;
@@ -288,10 +297,14 @@ private function updateAnswerData()
                     $newData = array_map(function ($coords) {
                         $coordsData = explode(',', $coords);
 
-                        return [
-                            $coordsData[0],
-                            $coordsData[1],
-                        ];
+                        if (!empty($coordsData) && 2 === count($coordsData)) {
+                            return [
+                                $coordsData[0],
+                                $coordsData[1],
+                            ];
+                        } else {
+                            return null;
+                        }
                     }, $answerData);
                     break;
 
@@ -303,9 +316,19 @@ private function updateAnswerData()
             $sth = $this->connection->prepare('
                 UPDATE ujm_response SET `response` = :data WHERE id = :id 
             ');
+
+            $insertData = null;
+            if (!empty($newData)) {
+                $insertData = json_encode(
+                    array_filter($newData, function ($data) {
+                        return !empty($data);
+                    })
+                );
+            }
+
             $sth->execute([
                 'id' => $answer['answerId'],
-                'data' => !empty($newData) ? json_encode($newData) : null,
+                'data' => $insertData,
             ]);
         }
 

plugin/exo/Installation/Updater/Updater090002.php

@@ -0,0 +1,58 @@
+<?php
+
+namespace UJM\ExoBundle\Installation\Updater;
+
+use Claroline\BundleRecorder\Log\LoggableTrait;
+use Doctrine\DBAL\Connection;
+
+class Updater090002
+{
+    use LoggableTrait;
+
+    /**
+     * @var Connection
+     */
+    private $connection;
+
+    /**
+     * Updater090002 constructor.
+     *
+     * @param Connection $connection
+     */
+    public function __construct(Connection $connection)
+    {
+        $this->connection = $connection;
+    }
+
+    public function postUpdate()
+    {
+        $this->fixQuizTypes();
+    }
+
+    private function fixQuizTypes()
+    {
+        $this->connection
+            ->prepare('
+                UPDATE ujm_exercise SET `type` = "summative" WHERE `type` = "1";
+            ')
+            ->execute();
+
+        $this->connection
+            ->prepare('
+                UPDATE ujm_exercise SET `type` = "summative" WHERE `type` = "sommatif";
+            ')
+            ->execute();
+
+        $this->connection
+            ->prepare('
+                UPDATE ujm_exercise SET `type` = "evaluative" WHERE `type` = "2";
+            ')
+            ->execute();
+
+        $this->connection
+            ->prepare('
+                UPDATE ujm_exercise SET `type` = "formative" WHERE `type` = "3";
+            ')
+            ->execute();
+    }
+}