Skip to content

Possible breaking change for this integration in core 2024.12.0. #71

@sbeaudoin

Description

@sbeaudoin

Upgraded to core 2024.12.0 and since then, the integration crash with the following :

Logger: homeassistant.components.climate
Source: helpers/entity_platform.py:825
integration: Climate (documentation, issues)
First occurred: 05:34:12 (3 occurrences)
Last logged: 05:34:12

Error adding entity None for domain climate with platform sinope
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 825, in _async_add_entity
    capabilities=entity.capability_attributes,
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/climate/__init__.py", line 337, in __getattribute__
    return super().__getattribute__(name)
           ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/climate/__init__.py", line 530, in capability_attributes
    data[ATTR_SWING_HORIZONTAL_MODES] = self.swing_horizontal_modes
                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/climate/__init__.py", line 337, in __getattribute__
    return super().__getattribute__(name)
           ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "src/propcache/_helpers_c.pyx", line 80, in propcache._helpers_c.cached_property.__get__
  File "/usr/src/homeassistant/homeassistant/components/climate/__init__.py", line 727, in swing_horizontal_modes
    return self._attr_swing_horizontal_modes
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/climate/__init__.py", line 337, in __getattribute__
    return super().__getattribute__(name)
           ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/climate/__init__.py", line 337, in __getattribute__
    return super().__getattribute__(name)
           ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
AttributeError: 'SinopeThermostat' object has no attribute '__attr_swing_horizontal_modes'. Did you mean: '_attr_swing_horizontal_modes'?

This seems to be due to a new fonctionality who requires all climate integration to declare the new attribute "_attr_swing_horizontal_modes". Opened a HA core ticket about this because if my interpretation is right, it could break all climate integration who don't declare this attribute.

I think it could also be solved if you declare this attribute on your side.

Don't flame me if I am wrong, I am new to HA and only trying to help.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions