Undefined return values in src/2d/shallow/surge/data_storm_module.f90

[rjleveque]

Compiling geoclaw with the ifx intel compiler gives these warnings:

/home1/04137/rjl/clawpack_src/clawpack-v5.13.1/geoclaw/src/2d/shallow/surge/data_storm_module.f90(480): warning #6178: The return value of this FUNCTION has not been defined.   [LOCATION]
    function storm_location(t,storm) result(location)
--------------------------------------------^
/home1/04137/rjl/clawpack_src/clawpack-v5.13.1/geoclaw/src/2d/shallow/surge/data_storm_module.f90(498): warning #6178: The return value of this FUNCTION has not been defined.   [THETA]
    real(kind=8) function storm_direction(t, storm) result(theta)
-----------------------------------------------------------^

[mandli]

That's odd. For the first example the return type real(kind=8) :: location(2) is defined in the function body and the second the return type is in the function definition. Also odd is that this only seems to trigger this for the data_storm_module.f90 versions of the functions, but they are also in storm_module.f90 and model_storm_module.f90. The one difference is that these functions, while present in data_storm_module.f90, are never called (the values are not well-defined when there is no center for the storm), but are present for consistency in the interface. Should keep an eye on this though to make sure that something is not going awry.