suppress plot made by make_shoreline_xy #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I was wondering if this was enough, or if
This does make me wonder if there are some areas, especially when animating, that we could possibly improve speed and/or memory footprint drastically by auditing the code and making sure we are consistently using these calls. |
Member
Author
|
Yes, I have run into cases when making animations in particular where it runs into memory problems if the figures aren't closed properly. I've never had to delete a figure after closing. As far as I can see for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
topotools.Topography.make_shoreline_xymakes a contour plot only to extract the contour lines.Close the figure so it doesn't appear when not wanted in a notebook.