Upgrade Dawarich with JWT secret#2274
Conversation
Update the Dawarich web and Sidekiq images to 1.7.7. Add a generated External Secrets password for JWT_SECRET_KEY and expose it to both Dawarich containers so the upgrade does not rely on the old unset JWT behavior.
There was a problem hiding this comment.
Pull request overview
Updates the Dawarich Kubernetes manifests to deploy Dawarich v1.7.7 and introduces a generated JWT_SECRET_KEY via External Secrets so the app no longer relies on the prior “unset JWT secret” behavior.
Changes:
- Bump
freikin/dawarichimage for both web and Sidekiq Deployments to1.7.7(pinned by digest). - Add a Password generator + ExternalSecret that materializes
JWT_SECRET_KEYinto a dedicated Secret. - Inject
JWT_SECRET_KEYinto both the web and Sidekiq containers viasecretKeyRef.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| kubernetes/dawarich/password-generators.yaml | Adds a new External Secrets Password generator for the Dawarich JWT secret. |
| kubernetes/dawarich/externalsecret.yaml | Adds an ExternalSecret that rewrites the generator output into the JWT_SECRET_KEY Secret key. |
| kubernetes/dawarich/deploy-web.yaml | Updates Dawarich web image to 1.7.7 and wires JWT_SECRET_KEY env var from the new Secret. |
| kubernetes/dawarich/deploy-sidekiq.yaml | Updates Sidekiq image to 1.7.7 and wires JWT_SECRET_KEY env var from the new Secret. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughThe PR updates Dawarich deployments from version 1.6.1 to 1.7.7 across sidekiq and web containers, and introduces a JWT secret management pipeline: a password generator produces a 64-character secret, an ExternalSecret resource creates and manages the Kubernetes secret via the production ClusterSecretStore, and both deployments consume it as the JWT_SECRET_KEY environment variable. ChangesDawarich JWT Secret Management
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Update the Dawarich web and Sidekiq images to 1.7.7.
Add a generated External Secrets password for JWT_SECRET_KEY and expose it to both Dawarich containers so the upgrade does not rely on the old unset JWT behavior.