Skip to content

Remove garagepi-eth Smokeping target#2312

Merged
claytono merged 1 commit into
mainfrom
remove-garagepi-eth-smokeping
Jun 2, 2026
Merged

Remove garagepi-eth Smokeping target#2312
claytono merged 1 commit into
mainfrom
remove-garagepi-eth-smokeping

Conversation

@claytono

@claytono claytono commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Drop the garagepi-eth DNS target from the repo-managed smokeping-prober config so the duplicate Ethernet endpoint is no longer probed.

Keep garagepi.oneill.net in the internal host group.

Operational note: the classic Smokeping PVC config is not tracked in this repo; /config/Targets and matching backup files were cleaned live and deployment/smokeping was restarted.

Drop the garagepi-eth DNS target from smokeping-prober so the duplicate Ethernet endpoint is no longer probed.

Keep garagepi.oneill.net in the internal host group.
Copilot AI review requested due to automatic review settings June 1, 2026 22:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the garagepi-eth.oneill.net Smokeping probe target, leaving garagepi.oneill.net as the sole probe for that host.

Changes:

  • Drop duplicate Ethernet endpoint target from internal hosts group in smokeping-prober config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The smokeping-prober monitoring configuration for internal hosts is updated: garagepi-eth.oneill.net is replaced with garagepi.oneill.net, and four additional internal hosts are added to the ICMP target list.

Changes

Smokeping Configuration Update

Layer / File(s) Summary
Internal hosts target list update
kubernetes/smokeping-prober/config.yaml
The "Internal hosts" ICMP monitoring group's target list is updated to remove garagepi-eth.oneill.net, add garagepi.oneill.net, and add infra1.oneill.net, pantrypi.oneill.net, deck.oneill.net, and fs2.oneill.net to the monitored hosts. Group-level probe settings remain interval: 1s, network: ip, protocol: icmp.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • claytono/infra#2243: Updates relate to garagepi-eth disabling; this PR adjusts smokeping to stop probing the wired interface and instead probe garagepi's wireless interface.
  • claytono/infra#1423: Both PRs modify the same smokeping-prober targets configuration to change which internal hosts are monitored.
  • claytono/infra#776: Both PRs update the smokeping-prober internal hosts target list to change monitored hostnames.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The PR title directly describes the main change: removing the garagepi-eth Smokeping target, which matches the primary modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description clearly relates to the changeset, explaining the removal of garagepi-eth and retention of garagepi.oneill.net in the smokeping config.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-garagepi-eth-smokeping

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@claytono claytono merged commit 93cba5c into main Jun 2, 2026
21 checks passed
@claytono claytono deleted the remove-garagepi-eth-smokeping branch June 2, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants