Use newer pyproject metadata licensing specifications#336
Use newer pyproject metadata licensing specifications#336cleder merged 2 commits intocleder:developfrom
Conversation
|
Review changes with |
Review Summary by QodoUpdate pyproject.toml to use modern license metadata specifications
WalkthroughsDescription• Modernize license specification in pyproject.toml to use SPDX identifier format • Replace deprecated [project.license] table with inline license field • Add license-files field to explicitly declare license file locations • Remove outdated LGPL classifier from project metadata File Changes1. pyproject.toml
|
Summary of ChangesHello @bkmgit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
PR Summary
|
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
for more information, see https://pre-commit.ci
|
Preparing review... |
Codacy's Analysis Summary0 new issue (≤ 0 issue) Review Pull Request in Codacy →
|
![llamapreview[bot]](https://avatars.githubusercontent.com/in/1023541?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto Pull Request Review from LlamaPReview
Review Status: Automated Review Skipped
Dear contributor,
Thank you for your Pull Request. LlamaPReview has analyzed your changes and determined that this PR does not require an automated code review.
Analysis Result:
PR contains only configuration changes to pyproject.toml to modernize license specifications, requiring no automated code review
We're continuously improving our PR analysis capabilities. Have thoughts on when and how LlamaPReview should perform automated reviews? Share your insights in our GitHub Discussions.
Best regards,
LlamaPReview Team
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the pyproject.toml file to use modern, standardized licensing metadata as per PEP 621 and PEP 639. The changes replace the deprecated [project.license] table and license classifier with the license and license-files keys. This is a good improvement. I have one piece of feedback regarding a potential build issue due to setuptools version compatibility.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 17e8bfe in 8 seconds. Click for details.
- Reviewed
24lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_lF56jCj7FTOpGJPj
You can customize 
Greptile SummaryThis PR modernizes the license metadata in Changes:
The changes correctly represent the existing LGPL 2.1 license and follow the guidance from the Python Packaging Authority documentation. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 0e18e74 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Code Review by Qodo
1. Wrong docs/ license file selected
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
pyproject.toml (1)
1-5:⚠️ Potential issue | 🟠 MajorBump
setuptoolsminimum to>=77for PEP 639 support.PEP 639 support (SPDX license expressions and
license-fileslist) was added in setuptools 77.0.0. The current constraintsetuptools>=61.2is insufficient and will fail to properly handle thelicenseandlicense-filesfields during builds.Proposed fix
requires = [ - "setuptools>=61.2", + "setuptools>=77", ]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pyproject.toml` around lines 1 - 5, Update the setuptools minimum requirement in the pyproject.toml build-system requires to ensure PEP 639 support: change the "setuptools" entry under requires from "setuptools>=61.2" to "setuptools>=77" so the build-backend ("setuptools.build_meta") will handle SPDX license expressions and license-files correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@pyproject.toml`:
- Around line 1-5: Update the setuptools minimum requirement in the
pyproject.toml build-system requires to ensure PEP 639 support: change the
"setuptools" entry under requires from "setuptools>=61.2" to "setuptools>=77" so
the build-backend ("setuptools.build_meta") will handle SPDX license expressions
and license-files correctly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #336 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 2709 2709
Branches 91 91
=========================================
Hits 2709 2709 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license
Important
Update
pyproject.tomlto use newer licensing specifications withlicenseandlicense-filesfields.licensefield inpyproject.tomlto"LGPL-2.1-or-later".license-filesfield with"LICENSE"and"docs/LICENSE.rst".project.licensesection.This description was created by
for 17e8bfe. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit