Skip to content

Commit d3cfe89

Browse files
kevinjqliuCopilot
andcommitted
add todo to remove top level parquet in v4.0.0
Co-authored-by: Copilot <copilot@github.com>
1 parent 1100bd5 commit d3cfe89

1 file changed

Lines changed: 9 additions & 8 deletions

File tree

tpchgen-cli/bin/main.rs

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -353,14 +353,15 @@ impl Cli {
353353
}
354354
}
355355

356-
self.args
357-
.common
358-
.builder(format)
359-
.with_parquet_compression(parquet_compression)
360-
.with_parquet_row_group_bytes(parquet_row_group_bytes)
361-
.build()
362-
.generate()
363-
.await
356+
let mut builder = self.args.common.builder(format);
357+
// TODO: Remove this block when the deprecated top-level --parquet-compression
358+
// and --parquet-row-group-bytes flags are removed in v4.0.0.
359+
if format == OutputFormat::Parquet {
360+
builder = builder
361+
.with_parquet_compression(parquet_compression)
362+
.with_parquet_row_group_bytes(parquet_row_group_bytes);
363+
}
364+
builder.build().generate().await
364365
}
365366
}
366367

0 commit comments

Comments
 (0)