Skip to content

ipc: a frame larger than max_payload_bytes closes the stream, indistinguishable from peer death #202

Description

@orionsutton

When a peer sends a frame whose Content-Length exceeds max_payload_bytes (hardcoded 64MB in src/ipc/transport.cpp), read_message stops the stream and returns the same nullopt as a real EOF. The receiver can't tell "this one message is too large" from "the connection died" — every pending request fails with the generic "transport closed".

Hit this in production with clice: a worker's index result for a big TU can exceed 64MB while being delivered normally. The master saw "transport closed", assumed the worker died, killed it and requeued — forever. Results up to 63.8MB delivered fine; anything bigger failed 100%.

Repro: frame a >64MB payload over a StreamTransport pair and read it.

We run a patch locally (drain the oversized frame, fail that request with a distinct error, make the cap configurable — the closed #200). Happy to rework it in whatever direction you land on.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions