[BUGFIX] #254 reset query builder on pagesUpdater

Author: mhirdes

Classes/Utility/DatabaseUtility.php

@@ -172,6 +172,7 @@ public static function migrateColumnNames($columnNamesToMigrate, $table)
         /** @var QueryBuilder $queryBuilder */
         $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
             ->getQueryBuilderForTable($table);
+
         foreach ($columnNamesToMigrate as $oldCol => $newCol) {
             $queryBuilder
                 ->update($table, 'u')
@@ -183,6 +184,8 @@ public static function migrateColumnNames($columnNamesToMigrate, $table)
                 )
                 ->set('u.' . $newCol, $queryBuilder->quoteIdentifier('u.' . $oldCol), false)
                 ->execute();
+            
+            $queryBuilder->resetQueryParts();
         }
     }
 
@@ -213,6 +216,8 @@ public static function migrateRelatedColumnContent($content, $column, $table, $t
                 )
                 ->set('u.' . $column, $queryBuilder->createNamedParameter($newContent), false)
                 ->execute();
+
+            $queryBuilder->resetQueryParts();
         }
     }
 }

Tests/Functional/Fixtures/pages.xml

@@ -11,4 +11,9 @@
 		<pid>1</pid>
 		<tx_csseo_canonical>https://www.clickstorm.de/</tx_csseo_canonical>
 	</pages>
+	<pages>
+		<uid>3</uid>
+		<pid>1</pid>
+		<seo_title>new title</seo_title>
+	</pages>
 </dataset>

Tests/Functional/Updates/PagesUpdaterTest.php

@@ -76,6 +76,12 @@ public function executeUpdateDataProvider()
                     'canonical_link' => 'https://www.clickstorm.de/'
                 ]
             ],
+            'page seo title already set' => [
+                3,
+                [
+                    'seo_title' => 'new title',
+                ]
+            ],
         ];
     }
 }