You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* dev: add Eastwood linting
For some other Etaoin wip, I wanted to address some reflection
warnings for new code and noticed we did not have any existing checks
for reflection. I find Eastwood helps out with this nicely.
In addition to reflection warnings, I also addressed some other issues
Eastwood reported:
- A booboo in a test assertion for
`etaoin.unit.unit-test/test-chrome-profile`.
Fixed!
- URL constructors are deprecated, starting with JDK 20.
I switched to using lambdaisland/uri.
- it noticed `is` assert messages that were not obviously strings.
I ^String type hinted the message generating fn.
- it thought string `"always"` for a constant truthy looked suspicious.
I switched to the more conventional `:always`.
- several tests had empty assertions like `(is true "text found")` or
`(is 1)`.
Perhaps some linter once warned about a test without assertions? We
don't have such a thing today, so I turfed these meaningless assertions.
The unwritten assertion for these tests is that they do not throw an
exception.
* add/ignore lint stuff
- add some kondo lib config brought in by kondo
- git ignore .eastwood dir
0 commit comments