Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage of test cases in test suite #640

Open
dgr opened this issue Aug 20, 2024 · 2 comments
Open

Improve coverage of test cases in test suite #640

dgr opened this issue Aug 20, 2024 · 2 comments

Comments

@dgr
Copy link
Contributor

dgr commented Aug 20, 2024

Problem/Opportunity
Today, most of the tests in the Etaoin test suite are positive tests that validate that Etaoin can do something. They test the "happy path." There are little to no test cases that validate Etaoin's behavior in error conditions.

Proposed Solution
The behavior of each API call under error conditions needs to be understood (see issue #639) and then tests written to validate the documented behavior.

Alternative Solutions
None. This is just grunt work.

Additional context
It always sucks writing negative test cases, but they're pretty important, particularly for something like Etaoin that purports to work across multiple browsers. Very few users have the time or ability to debug error cases across multiple browsers. The Etaoin project infrastructure does this routinely, however, so all that needs to be done (he says, blithely, waving his hands) is to add negative test cases to the existing Etaoin test suite.

@dgr dgr changed the title Improve coverage of negative test cases in test suite Improve coverage of test cases in test suite Aug 23, 2024
@dgr
Copy link
Contributor Author

dgr commented Aug 23, 2024

Changed name to reflect that it isn't just about negative tests, though those are very important.

@lread
Copy link
Collaborator

lread commented Aug 24, 2024

Ok, but please be aware that some % of test coverage is not a goal.
Once you run a coverage tool, it can be tempting to strive for 100% coverage.
That is not a goal for Etaoin and never will be.

@dgr dgr mentioned this issue Sep 14, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants