Skip to content

docs: add caveat about import-vars? #68

Open
@lread

Description

Some time ago I merged rewrite-cljs v0 and rewrite-clj v0 to create rewrite-clj v1.

Rewrite-clj v0 used an inlined version of potemkin import-vars.
My initial decision was to create an inlined cljs version of import-vars to match.
This was a ton of learning and effort, but it technically worked.

Over time I discovered import-vars does has enough downsides that I ultimately decided to switch to code generation instead. Here are my rewrite-clj v1 notes on import-vars.

So that users can make a more informed choice, I think we should probably mention some of the cons of using import-vars in the readme. I am happy to take a stab at this.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions