zip/right does not skip over uneval nodes

[plexus]

rewrite-clj.zip/right skips over whitespace, comments, commas, newlines, but does not skip over uneval nodes.

I thought this was quite surprising. Is this intentional?

[plexus]

@xsc could you comment on this? would you consider accepting a PR that changes this behavior?

In Depot we now have our own versions of left/right/next all to deal with uneval nodes. Every time we accidentally use rewrite-clj.zip/right or next instead of our own version we run into problems. See https://github.com/Olical/depot/blob/master/src/depot/zip.clj

[lread]

Hi @plexus, since this could break things like code formatters, do you think it should it be an option when creating the zipper?

[plexus]

The first question is if it's a bug or a feature. If it's a bug then I think the right thing to do is to add a rewrite-clj.zip2 namespace with the new behavior, or add variants of left/right/next to rewrite-clj.zip with different names. That way you don't break existing consumers.

If it's a feature then we'll just continue to work around it outside of rewrite-clj

[sogaiu]

I would also prefer to have the behavior of uneval being skipped if comments are configured to be skipped.

On a related note, I'm investigating the idea of a zipper that doesn't skip comments but does skip whitespace. Is a general mechanism for tweaking / configuring what is skipped at zipper-creation time of any interest?

[borkdude]

What if one wanted to rewrite the uneval nodes?