Skip to content

Commit 1ea07e3

Browse files
committed
Clean up cider-popup.el and cider-jar.el for standalone use
These two modules have no CIDER-specific dependencies and can be used independently by other Emacs packages. - cider-jar.el: Fix cider-jar-clojars-url to use the artifact name instead of hardcoding "cider-nrepl" in the URL path - cider-eval.el: Remove unused (require 'cider-jar) - Update commentary in both files to document their standalone nature
1 parent 9a6c2eb commit 1ea07e3

3 files changed

Lines changed: 8 additions & 5 deletions

File tree

lisp/cider-eval.el

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@
5252

5353
(require 'cider-client)
5454
(require 'cider-common)
55-
(require 'cider-jar)
5655
(require 'cider-overlays)
5756
(require 'cider-popup)
5857
(require 'cider-repl)

lisp/cider-jar.el

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,10 @@
2121

2222
;;; Commentary:
2323

24-
;; Dealing with JAR (Java archive) files, which are really just zip files in
25-
;; disguise. In particular downloading and retrieving the cider-nrepl jar.
24+
;; Generic JAR (Java archive) file handling - downloading, caching,
25+
;; listing contents, and extracting files. JARs are really just zip
26+
;; files in disguise. This module has no CIDER-specific dependencies
27+
;; and can be used by any Emacs package that works with JVM artifacts.
2628

2729
;;; Code:
2830

@@ -43,7 +45,7 @@ This provides an efficient check to see if a file exists in a jar or not.")
4345
GROUP, ARTIFACT, and VERSION are the components of the Maven coordinates."
4446
(concat "https://repo.clojars.org/" group "/" artifact "/"
4547
version
46-
"/cider-nrepl-"
48+
"/" artifact "-"
4749
version
4850
".jar"))
4951

lisp/cider-popup.el

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@
1919

2020
;;; Commentary:
2121

22-
;; Common functionality for dealing with popup buffers.
22+
;; Generic popup buffer management for displaying temporary content.
23+
;; This module has no CIDER-specific dependencies and can be used by
24+
;; any Emacs package that needs popup buffer functionality.
2325

2426
;;; Code:
2527

0 commit comments

Comments
 (0)