Round 24 fixes: chain JSON parse error, contain log-file import side effect

- _load_permission_data now reports both JSON and YAML parse errors
  in the ValueError message. A user feeding a JSON file with a syntax
  error was previously shown only the downstream YAML error, which
  described the file in YAML-grammar terms and was confusing.
- TestPermissionFileParsing.setUpClass chdir's to ROOT around the
  exec_module call. The module's top-level dictConfig writes
  provider-kubeconfig.log via RotatingFileHandler with a relative
  path; the log now lands in the gitignored location regardless of
  where pytest was invoked from.

Author: anniegracehu

provider-kubeconfig.py

@@ -54,11 +54,13 @@ def _load_permission_data(self, permissionfile):
                     contents = fp.read()
                 try:
                     perms_data = json.loads(contents)
-                except json.JSONDecodeError:
+                except json.JSONDecodeError as json_exc:
                     try:
                         perms_data = yaml.safe_load(contents)
-                    except yaml.YAMLError as exc:
-                        raise ValueError(f"Permission file is neither valid JSON nor YAML: {exc}") from exc
+                    except yaml.YAMLError as yaml_exc:
+                        raise ValueError(
+                            f"Permission file is neither valid JSON ({json_exc}) nor YAML ({yaml_exc})."
+                        ) from yaml_exc
                 if not isinstance(perms_data, dict) or "perms" not in perms_data:
                     raise ValueError("Permission file must define a top-level 'perms' object.")
                 if not isinstance(perms_data["perms"], dict):

tests/test_provider_kubeconfig.py

@@ -92,7 +92,15 @@ def setUpClass(cls):
         script_path = os.path.join(ROOT, SCRIPT)
         spec = importlib.util.spec_from_file_location("provider_kubeconfig_module", script_path)
         module = importlib.util.module_from_spec(spec)
-        spec.loader.exec_module(module)
+        # The module's top-level dictConfig creates provider-kubeconfig.log in cwd as a
+        # side effect of import. Run the import with cwd=ROOT so the file lands in the
+        # gitignored location regardless of where pytest was invoked from.
+        prev_cwd = os.getcwd()
+        os.chdir(ROOT)
+        try:
+            spec.loader.exec_module(module)
+        finally:
+            os.chdir(prev_cwd)
         cls.generator = module.KubeconfigGenerator()
 
     def _write_temp_file(self, suffix, content):