refactor: unify CLI field attributes and remove dead code

Change #[clap(..)] to #[arg(..)] on field-level attributes across jira,
confluence, hackernews, and markdown CLI structs. Remove unused Serialize
derives from option structs that are never serialized, and clean up dead
imports and variables.

Author: cloudbridgeuy

crates/mcptools/src/atlassian/confluence.rs

@@ -1,6 +1,6 @@
 use super::{create_confluence_client, ConfluenceConfig};
 use crate::prelude::{eprintln, println, *};
-use serde::{Deserialize, Serialize};
+use serde::Deserialize;
 
 // Import domain models and pure functions from core crate
 use mcptools_core::atlassian::confluence::transform_search_results;
@@ -17,10 +17,10 @@ pub enum Commands {
 }
 
 /// Options for searching Confluence pages
-#[derive(Debug, clap::Args, Serialize, Deserialize, Clone)]
+#[derive(Debug, clap::Args, Deserialize, Clone)]
 pub struct SearchOptions {
     /// CQL query (e.g., "space = SPACE AND text ~ 'keyword'")
-    #[clap(env = "CONFLUENCE_QUERY")]
+    #[arg(env = "CONFLUENCE_QUERY")]
     pub query: String,
 
     /// Maximum number of results to return
@@ -95,7 +95,6 @@ async fn search_handler(options: SearchOptions) -> Result<()> {
         let mut table = crate::prelude::new_table();
         table.add_row(prettytable::row!["Title", "Type", "URL"]);
 
-        let num_pages = data.pages.len();
         for page in data.pages {
             let url = page.url.unwrap_or_else(|| "N/A".to_string());
             table.add_row(prettytable::row![page.title, page.page_type, url]);

crates/mcptools/src/atlassian/jira/get.rs

@@ -1,16 +1,16 @@
 use mcptools_core::atlassian::jira::{
-    transform_ticket_response, JiraComment, JiraExtendedIssueResponse, TicketOutput,
+    transform_ticket_response, JiraExtendedIssueResponse, TicketOutput,
 };
-use serde::{Deserialize, Serialize};
+use serde::Deserialize;
 
 use crate::atlassian::{create_jira_client, JiraConfig};
 use crate::prelude::{println, *};
 
 /// Options for getting a Jira ticket
-#[derive(Debug, clap::Args, Serialize, Deserialize, Clone)]
+#[derive(Debug, clap::Args, Deserialize, Clone)]
 pub struct GetOptions {
     /// Issue key (e.g., "PROJ-123")
-    #[clap(env = "JIRA_ISSUE_KEY")]
+    #[arg(env = "JIRA_ISSUE_KEY")]
     pub issue_key: String,
 
     /// Output as JSON

crates/mcptools/src/atlassian/jira/search.rs

@@ -1,13 +1,13 @@
 use crate::prelude::{eprintln, println, *};
-use serde::{Deserialize, Serialize};
+use serde::Deserialize;
 use std::path::PathBuf;
 
 // Import domain models and pure functions from core crate
 use mcptools_core::atlassian::jira::transform_search_response;
 pub use mcptools_core::atlassian::jira::{IssueOutput, JiraSearchResponse, SearchOutput};
 
 /// Options for searching Jira issues
-#[derive(Debug, clap::Args, Serialize, Deserialize, Clone)]
+#[derive(Debug, clap::Args, Deserialize, Clone)]
 #[command(after_help = "EXAMPLES:
   # Get all tickets assigned to the current user:
   mcptools atlassian jira search \"assignee = currentUser()\"
@@ -60,7 +60,7 @@ NOTES:
   - Saved queries are stored in ~/.config/mcptools/queries/")]
 pub struct SearchOptions {
     /// JQL query (e.g., "project = PROJ AND status = Open"), optional when using --query, --list, --load, or --delete
-    #[clap(env = "JIRA_QUERY")]
+    #[arg(env = "JIRA_QUERY")]
     pub jql_query: Option<String>,
 
     /// Maximum number of results to return per page

crates/mcptools/src/hn/list_items.rs

@@ -7,7 +7,7 @@ use mcptools_core::hn::{
 
 use super::{fetch_item, get_api_base};
 
-#[derive(Debug, clap::Args, serde::Serialize, serde::Deserialize, Clone)]
+#[derive(Debug, clap::Args, serde::Deserialize, Clone)]
 pub struct ListOptions {
     /// Story type: top, new, best, ask, show, job
     #[arg(value_name = "TYPE", default_value = "top")]

crates/mcptools/src/hn/read_item.rs

@@ -10,10 +10,10 @@ use serde::Serialize;
 
 use super::{extract_item_id, fetch_item, truncate_text};
 
-#[derive(Debug, clap::Args, serde::Serialize, serde::Deserialize, Clone)]
+#[derive(Debug, clap::Args, serde::Deserialize, Clone)]
 pub struct ReadOptions {
     /// HackerNews item ID or full URL (e.g., "45440028" or "https://news.ycombinator.com/item?id=45440028")
-    #[clap(env = "HN_ITEM")]
+    #[arg(env = "HN_ITEM")]
     pub item: String,
 
     /// Number of top-level comments per page

crates/mcptools/src/md/fetch.rs

@@ -4,10 +4,10 @@ use std::io::IsTerminal;
 
 use super::{fetch_and_convert_data, FetchOutput, SelectionStrategy};
 
-#[derive(Debug, clap::Args, serde::Serialize, serde::Deserialize, Clone)]
+#[derive(Debug, clap::Args, serde::Deserialize, Clone)]
 pub struct FetchOptions {
     /// URL to fetch
-    #[clap(env = "MD_URL")]
+    #[arg(env = "MD_URL")]
     pub url: String,
 
     /// Timeout in seconds (default: 30)

crates/mcptools/src/md/mod.rs

@@ -7,7 +7,7 @@ use std::time::Instant;
 
 pub use mcptools_core::md::{FetchOutput, MdPaginationInfo};
 
-#[derive(Debug, Clone, clap::ValueEnum, serde::Serialize, serde::Deserialize)]
+#[derive(Debug, Clone, clap::ValueEnum, serde::Deserialize)]
 #[serde(rename_all = "lowercase")]
 pub enum SelectionStrategy {
     /// Select the first matching element (default)

crates/mcptools/src/md/toc.rs

@@ -6,10 +6,10 @@ use std::io::IsTerminal;
 
 use super::{fetch_and_convert_data, SelectionStrategy};
 
-#[derive(Debug, clap::Args, serde::Serialize, serde::Deserialize, Clone)]
+#[derive(Debug, clap::Args, serde::Deserialize, Clone)]
 pub struct TocOptions {
     /// URL to fetch
-    #[clap(env = "MD_URL")]
+    #[arg(env = "MD_URL")]
     pub url: String,
 
     /// Timeout in seconds (default: 30)
@@ -37,7 +37,7 @@ pub struct TocOptions {
     pub json: bool,
 }
 
-#[derive(Debug, Clone, clap::ValueEnum, serde::Serialize, serde::Deserialize)]
+#[derive(Debug, Clone, clap::ValueEnum, serde::Deserialize)]
 #[serde(rename_all = "lowercase")]
 pub enum OutputFormat {
     /// Indented text format (2 spaces per level)