Merge pull request #23 from TP125487/library-improvements

Library improvements

Author: josiasmontag

CloudConvert.API/CloudConvert.API.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net461;netstandard2.1;net5.0</TargetFrameworks>
+    <TargetFrameworks>net8.0</TargetFrameworks>
     <AssemblyName>CloudConvert.API</AssemblyName>
     <RootNamespace>CloudConvert.API</RootNamespace>
     <Description>Official SDK for the CloudConvert API</Description>

CloudConvert.API/CloudConvertAPI.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Globalization;
 using System.IO;
 using System.Linq;
 using System.Net.Http;

CloudConvert.API/Models/Enums/ThumbnailFit.cs

@@ -1,6 +1,6 @@
 namespace CloudConvert.API.Models.Enums
 {
-    public enum ThumbnailFit 
+  public enum ThumbnailFit 
   { 
     max, 
     crop,

CloudConvert.API/Models/TaskOperations/WatermarkCreateRequest.cs

@@ -1,7 +1,5 @@
 using Newtonsoft.Json;
-using Newtonsoft.Json.Converters;
 using System.Collections.Generic;
-using CloudConvert.API.Models.Enums;
 
 namespace CloudConvert.API.Models.TaskOperations
 {

CloudConvert.Test/CloudConvert.Test.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net461;netcoreapp3.1;net5.0</TargetFrameworks>
+    <TargetFrameworks>net8.0</TargetFrameworks>
 
     <IsPackable>false</IsPackable>
   </PropertyGroup>

CloudConvert.Test/IntegrationTests.cs

@@ -1,17 +1,13 @@
 using System.IO;
 using System.Linq;
-using System.Net;
 using System.Threading.Tasks;
 using NUnit.Framework;
 using CloudConvert.API;
-using CloudConvert.API.Models.Enums;
 using CloudConvert.API.Models.ExportOperations;
 using CloudConvert.API.Models.ImportOperations;
-using CloudConvert.API.Models.TaskOperations;
 using CloudConvert.API.Models.JobModels;
-
-using System.Collections.Generic;
 using System;
+using System.Net.Http;
 
 namespace CloudConvert.Test
 {
@@ -82,7 +78,9 @@ public async Task CreateJob(string streamingMethod)
       Assert.IsNotNull(fileExport);
       Assert.AreEqual(fileExport.Filename, "input.pdf");
 
-      using (var client = new WebClient()) client.DownloadFile(fileExport.Url, fileExport.Filename);
+      using var httpClient = new HttpClient();
+      var fileBytes = await httpClient.GetByteArrayAsync(fileExport.Url);
+      await File.WriteAllBytesAsync(fileExport.Filename, fileBytes);
     }
 
     [TestCase("stream")]
@@ -140,8 +138,9 @@ public async Task CreateTask(string streamingMethod)
       Assert.IsNotNull(fileExport);
       Assert.AreEqual(fileExport.Filename, "input.pdf");
 
-      using (var client = new WebClient()) client.DownloadFile(fileExport.Url, fileExport.Filename);
-
+      using var httpClient = new HttpClient();
+      var fileBytes = await httpClient.GetByteArrayAsync(fileExport.Url);
+      await File.WriteAllBytesAsync(fileExport.Filename, fileBytes);
     }
   }
 }

CloudConvert.Test/TestTasks.cs

@@ -1,12 +1,9 @@
 using System;
 using System.IO;
-using System.Net;
 using System.Net.Http;
-using System.Threading;
 using System.Threading.Tasks;
 using CloudConvert.API;
 using CloudConvert.API.Models;
-using CloudConvert.API.Models.Enums;
 using CloudConvert.API.Models.ImportOperations;
 using CloudConvert.API.Models.TaskModels;
 using CloudConvert.API.Models.TaskOperations;