[CYB-223] upgrade all junit tests to use junit 5

* Upgrade all JUnit tests from JUnit 4 to JUnit 5

- Converted 89 JUnit 4 test files to JUnit 5 Jupiter format
- Updated imports: org.junit.* → org.junit.jupiter.api.*
- Converted annotations: @BeforeClass → @BeforeAll, @afterclass → @afterall
- Updated assertions: Assert.* → Assertions.*
- Fixed hamcrest imports: MatcherAssertions → MatcherAssert
- Removed JUnit 4 dependencies from parent and all 24+ child module POMs
- Added JUnit 5 Jupiter dependencies with proper version management
- Cleaned up JUnit dependencies from plugin sections
- Fixed test scope dependencies in metron-enrichment-common
- Verified JUnit 5 migration with standalone test

All 330 test files now use JUnit 5 Jupiter.
JUnit 4 dependencies completely removed from the project.

Co-authored-by: openhands <[email protected]>

* Fix JUnit 5 migration build failures

- Add JUnit 5 dependencies to parent pom.xml with proper version management
- Add JUnit 5 dependencies to cyber-functions and flink-common modules
- Update Maven compiler plugin to 3.11.0 for better Java compatibility
- Configure Maven Surefire plugin for JUnit 5 support
- Update Lombok version to 1.18.30 for compatibility
- Fix JUnit 5 assertion parameter order in GeneratorScenarioTest.java

Co-authored-by: openhands <[email protected]>

* Correct build and unit test errors

* Correct build and unit test errors

* Enable HbaseBatchEnrichmentCSVLoaderTest

* Remove duplicate junit.jupiter dependency

---------

Co-authored-by: openhands <[email protected]>

Author: carolynduby

flink-cyber/caracal-generator/pom.xml

@@ -39,13 +39,6 @@
             <artifactId>flink-connector-kafka</artifactId>
         </dependency>
 
-        <dependency>
-            <groupId>org.apache.flink</groupId>
-            <artifactId>flink-clients</artifactId>
-            <scope>provided</scope>
-            <version>${flink.version}</version>
-        </dependency>
-
         <dependency>
             <groupId>com.hortonworks.smm</groupId>
             <artifactId>monitoring-interceptors</artifactId>
@@ -87,7 +80,6 @@
             <scope>provided</scope>
         </dependency>
 
-
         <dependency>
             <groupId>com.cloudera.cyber</groupId>
             <artifactId>flink-logging</artifactId>
@@ -96,14 +88,14 @@
         </dependency>
 
         <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <scope>test</scope>
+            <groupId>com.fasterxml.jackson.core</groupId>
+            <artifactId>jackson-databind</artifactId>
         </dependency>
 
         <dependency>
-            <groupId>com.fasterxml.jackson.core</groupId>
-            <artifactId>jackson-databind</artifactId>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter</artifactId>
+            <scope>test</scope>
         </dependency>
 
         <dependency>
@@ -119,13 +111,6 @@
             <scope>test</scope>
         </dependency>
 
-        <dependency>
-            <groupId>com.salesforce.kafka.test</groupId>
-            <artifactId>kafka-junit4</artifactId>
-            <version>3.2.1</version>
-            <scope>test</scope>
-        </dependency>
-
         <dependency>
             <groupId>org.apache.kafka</groupId>
             <artifactId>kafka_${scala.binary.version}</artifactId>

flink-cyber/caracal-generator/src/test/java/com/cloudera/cyber/test/GeneratorTests.java

@@ -17,14 +17,16 @@
 import com.fasterxml.jackson.databind.type.MapType;
 import com.fasterxml.jackson.databind.type.TypeFactory;
 import freemarker.template.TemplateException;
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.Timeout;
 
 import java.io.IOException;
 import java.net.URISyntaxException;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.concurrent.TimeUnit;
 
 import static org.hamcrest.CoreMatchers.equalTo;
 import static org.hamcrest.CoreMatchers.notNullValue;
@@ -74,7 +76,8 @@ public void testNetflowHttp() throws IOException, TemplateException {
     }
 
 
-    @Test(timeout = 1000)
+    @Test
+    @Timeout(value = 1, unit = TimeUnit.SECONDS)
     public void testBulkProduction10000eps() throws IOException, TemplateException {
         FreemarkerImmediateGenerator generator = new FreemarkerImmediateGenerator();
         for (int i = 0; i < 10000; i++) {
@@ -86,12 +89,12 @@ public void testBulkProduction10000eps() throws IOException, TemplateException {
     private Map<String, Object> testFile(String file) throws IOException, TemplateException {
         FreemarkerImmediateGenerator generator = new FreemarkerImmediateGenerator();
         String result = generator.generateEntry(file);
-        Assert.assertNotNull(result);
+        Assertions.assertNotNull(result);
         ObjectMapper mapper = new ObjectMapper();
         TypeFactory typeFactory = mapper.getTypeFactory();
         MapType mapType = typeFactory.constructMapType(HashMap.class, String.class, Object.class);
         Map<String, Object> output = mapper.readValue(result, mapType);
-        Assert.assertNotNull(output);
+        Assertions.assertNotNull(output);
         return output;
     }
 

flink-cyber/caracal-generator/src/test/java/com/cloudera/cyber/test/RandomGeneratorTests.java

@@ -13,9 +13,9 @@
 package com.cloudera.cyber.test;
 
 import com.cloudera.cyber.generator.RandomGenerators;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
-import static org.junit.Assert.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 
 public class RandomGeneratorTests {
 

flink-cyber/caracal-generator/src/test/java/com/cloudera/cyber/test/TestCaracalGeneratorJob.java

@@ -20,8 +20,8 @@
 import org.apache.flink.streaming.api.datastream.SingleOutputStreamOperator;
 import org.apache.flink.test.util.CollectingSink;
 import org.apache.flink.test.util.JobTester;
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
 
 import java.time.Duration;
 import java.util.*;
@@ -101,7 +101,7 @@ private void checkGeneratedResults(int expectedCount, List<String> expectedTopic
         for (int i = 0; i < expectedCount; i++) {
             Tuple2<String, byte[]> generatedRecord = sink.poll(Duration.ofMillis(100));
             String actualTopic = generatedRecord.f0;
-            Assert.assertTrue(String.format("Generated topic '%s' is not in expected topics '%s'", actualTopic, expectedTopics), expectedTopics.contains(actualTopic));
+            Assertions.assertTrue(expectedTopics.contains(actualTopic),String.format("Generated topic '%s' is not in expected topics '%s'", actualTopic, expectedTopics));
             results.add(generatedRecord);
         }
 

flink-cyber/caracal-generator/src/test/java/com/cloudera/cyber/test/ThreatGeneratorTest.java

@@ -14,12 +14,12 @@
 
 import com.cloudera.cyber.generator.ThreatGenerator;
 import freemarker.template.TemplateException;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.io.IOException;
 
 import static org.hamcrest.Matchers.containsString;
-import static org.junit.Assert.assertThat;
+import static org.hamcrest.MatcherAssert.assertThat;
 
 public class ThreatGeneratorTest {
 

flink-cyber/caracal-parser/pom.xml

@@ -141,13 +141,30 @@
             <scope>provided</scope>
         </dependency>
 
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter</artifactId>
+            <scope>test</scope>
+        </dependency>
+
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter-engine</artifactId>
+            <scope>test</scope>
+        </dependency>
 
         <dependency>
             <groupId>org.apache.flink</groupId>
             <artifactId>flink-test-utils</artifactId>
             <scope>test</scope>
         </dependency>
 
+        <dependency>
+            <groupId>org.hamcrest</groupId>
+            <artifactId>hamcrest</artifactId>
+            <scope>test</scope>
+        </dependency>
+
         <dependency>
             <groupId>org.apache.flink</groupId>
             <artifactId>flink-sequence-file</artifactId>
@@ -189,15 +206,11 @@
             </exclusions>
         </dependency>
 
-        <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <scope>test</scope>
-        </dependency>
         <dependency>
             <groupId>org.adrianwalker</groupId>
             <artifactId>multiline-string</artifactId>
         </dependency>
+
     </dependencies>
 
     <build>
@@ -255,6 +268,22 @@
                     </execution>
                 </executions>
             </plugin>
+
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-surefire-plugin</artifactId>
+                <version>${maven-surefire-plugin.version}</version>
+                <configuration>
+                    <useSystemClassLoader>false</useSystemClassLoader>
+                </configuration>
+                <dependencies>
+                    <dependency>
+                        <groupId>org.junit.jupiter</groupId>
+                        <artifactId>junit-jupiter-engine</artifactId>
+                        <version>${junit5.version}</version>
+                    </dependency>
+                </dependencies>
+            </plugin>
         </plugins>
     </build>
 </project>

flink-cyber/caracal-parser/src/test/java/com/cloudera/cyber/caracal/ParserChainMapFunctionTest.java

@@ -18,7 +18,7 @@
 import lombok.NonNull;
 import org.adrianwalker.multilinestring.Multiline;
 import org.apache.flink.api.java.utils.ParameterTool;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.security.KeyPair;
 import java.security.KeyPairGenerator;

flink-cyber/caracal-parser/src/test/java/com/cloudera/cyber/caracal/SplittingFlatMapFunctionTest.java

@@ -16,7 +16,7 @@
 import com.cloudera.cyber.TestUtils;
 import org.apache.flink.configuration.Configuration;
 import org.apache.flink.util.Collector;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.security.KeyPair;
 import java.security.KeyPairGenerator;

flink-cyber/caracal-parser/src/test/java/com/cloudera/cyber/caracal/TestSplitJob.java

@@ -25,7 +25,7 @@
 import org.apache.flink.test.util.CollectingSink;
 import org.apache.flink.test.util.JobTester;
 import org.apache.flink.test.util.ManualSource;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.io.IOException;
 import java.security.KeyPair;

flink-cyber/cyber-functions/pom.xml

@@ -30,7 +30,6 @@
             <scope>compile</scope>
         </dependency>
 
-
         <dependency>
             <groupId>org.apache.flink</groupId>
             <artifactId>flink-table-common</artifactId>
@@ -61,13 +60,13 @@
         </dependency>
 
         <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
+            <groupId>org.hamcrest</groupId>
+            <artifactId>hamcrest</artifactId>
             <scope>test</scope>
         </dependency>
         <dependency>
-            <groupId>org.hamcrest</groupId>
-            <artifactId>hamcrest</artifactId>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter</artifactId>
             <scope>test</scope>
         </dependency>
         <dependency>
@@ -80,7 +79,7 @@
             <artifactId>lombok</artifactId>
             <scope>compile</scope>
         </dependency>
+            
     </dependencies>
 
-
 </project>