Psr\Log prevents other plugins from being activated

[davidbarratt]

Confirmation

• My issue isn't already found on the issue tracker.
• I have replicated my issue using the latest version of the plugin and it is still present.

WordPress version

6.8.2

Cloudflare-WordPress version

4.12.8

PHP version

8.4.10

Expected result

I expected to be able to activate Flex HSA/FSA Payments alongside Cloudflare without any issues.

Actual result

A fatal error see JoinFlexHealth/woocommerce#1

Steps to reproduce

1. Enable Cloudflare
2. Attempt to enable Flex HSA/FSA Payments

Additional factoids

This appears to be because psr/log is in an incompatible version. I think this could be solved by using the Jetpack Autoloader

References

• PHP 8.2 Compatibility #528
• Dependency on Psr/log breaks sites using different versions #490
• Update psr/log to 3.0 #470
• Allow psr/log v3 when using composer #541
• Support for PHP 8 #539

[davidbarratt]

Interesting, so using Jetpack Autoloader results in this error:

PHP Fatal error: Declaration of CF\Integration\DefaultLogger::debug($message, array $context = []) must be compatible with Psr\Log\AbstractLogger::debug(Stringable|string $message, array $context = []): void in cloudflare/src/Integration/DefaultLogger.php on line 42

If this plugin wants to use an older version of Psr\Log (on an unsupported version of PHP) I feel like the best solution here is to prefix the dependency?

[davidbarratt]

Here are the options that I can think of and I would appreciate any feedback from @jacobbednarz (or anyone at @cloudflare)

1. Use the latest version of psr/log and bump support to PHP 8.0.0+, a version of PHP that entered end-of-life (EOL) nearly 2 years ago.
   1. Also use Jetpack Autoloader to avoid this problem in the future.
2. Copy the interfaces from the spec into the code.
3. Use PHP Scoper to modify the namespace of the dependencies.
4. Do nothing and ask every other plugin to namespace their dependencies instead.

What do you think?

[timofey-drozhzhin]

This is pretty major bug! It took out our website also.

This plugin was written for an older PSR-3 specification, which is now completely outdated.

Since the namespaces are shared among all plugins, any time another plugin or library loads the current PSR-3 interface, Cloudflare plugin will produce a system-wide fatal error.

In my case, since we're using OpenTelemetry, which relies on the current PSR-3 specification, Cloudflare ended up crashing our website.

[timofey-drozhzhin]

Just noticed there's a pull request for this #555

[zak-wearecore]

We are having issues with this across all of our Roots Bedrock/Sage Wordpress projects

[iugo-robert]

Can we please get a fix for this, we're seeing this error when trying to activate rollbar.

PHP Fatal error: Declaration of Monolog\Logger::emergency(Stringable|string $message, array $context = []): void must be compatible with Psr\Log\LoggerInterface::emergency($message, array $context = []) in wp-content/plugins/rollbar/vendor/monolog/monolog/src/Monolog/Logger.php on line 683

The Cloudflare plugin bundles monolog/monolog via Composer but does not vendor-prefix or otherwise isolate its dependencies. This causes a version conflict when another plugin (such as Rollbar) includes a different version of PSR/Log.

Could you please vendor-prefix all Rollbar dependencies in the distributed plugin build to prevent these kinds of conflicts with other WordPress plugins? Tools like Mozart or PHP-Scoper could be used to achieve this.

[remkus]

@iugo-robert We've got our first update out yesterday fixing mostly outdated PHP related issues, but yes, a fix for this will follow soon. We're very much aware of this issue and others like it and it has our (@barrykooij and I) highest priority to fix.

[jordantrizz]

@remkus might I suggest using labels for the current issues? For instance if this was tagged with planned and priority then overall users will get a better idea on the situation for each issue.

[remkus]

For security reasons, we're a bit limited what we can do in this repo, but we are already looking into this. Because, yes, more order is better.

[JshGrn]

Is there an ETA for this? A really simple fix would be just prefixing this dependency which would temporarily solve this issue unless perhaps I am missing something?

EDIT: Looking at the open PR, @remkus is this not a quick win? https://github.com/cloudflare/Cloudflare-WordPress/pull/555/files

[Dyras]

Sadly, Cloudflare seems to have no plans of ever fixing this. I'm really curious as to why this issue in particular seems unsolvable for the past year and a half.

[barrykooij]

Hey all. Barry here, I'm working with Cloudflare (with @remkus) to maintain and develop their WordPress plugin.

I've added "vendor prefixing" all of our dependencies to my todo list of the next version. This will solve this issue and any other issue we might run into with conflicting dependencies.

I'll keep you all updated via this issue ticket.

[JshGrn]

Right now I am using my own privately forked version with the open PR changes + some other amends. We will have to stay on this version until this is fixed, is there any form of ETA at all? This completely breaks Roots Radicle / Roots Acorn WP sites.

[remkus]

There's no ETA yet, but it has the highest priority. So, think in terms of months, I guess.