improve Go workflow checks (#8)

* download Go dependencies before Bonk runs

* check modernize in CI

* apply modernize rewrites

* fix linux modernize rewrite

Author: elithrar

.github/workflows/bonk.yml

@@ -31,6 +31,9 @@ jobs:
         with:
           go-version-file: go.mod
 
+      - name: Download Go dependencies
+        run: go mod download
+
       - name: Run Bonk
         uses: ask-bonk/ask-bonk/github@main
         env:

.github/workflows/build-test.yml

@@ -20,6 +20,11 @@ jobs:
         with:
           go-version-file: go.mod
 
+      - name: Check modernize
+        run: |
+          go run golang.org/x/tools/go/analysis/passes/modernize/cmd/modernize@latest -fix ./...
+          git diff --exit-code
+
       - name: Build
         run: go build ./cmd/artifact-fs
 

internal/daemon/mount_check_darwin.go

@@ -14,7 +14,7 @@ func isMounted(path string) bool {
 	if err != nil {
 		return false
 	}
-	for _, line := range strings.Split(string(out), "\n") {
+	for line := range strings.SplitSeq(string(out), "\n") {
 		if strings.Contains(line, " on "+path+" (") || strings.Contains(line, " on /private"+path+" (") {
 			return true
 		}