Move ed25519 checkpoint signer to tlog_tiles crate

* Move StandardEd25519CheckpointSigner to tlog_tiles crate, as it is the
  default checkpoint signer used by the tlog-tiles spec, and drop the
  'Standard' prefix.
* Rename StandardSigner -> Ed25519NoteSigner, signed_note::{Signer,
  Verifier} -> signed_note::Note{Signer,Verifier}

Author: lukevalenta

Cargo.lock

@@ -38,7 +38,7 @@ console_error_panic_hook = "0.1.1"
 console_log = { version = "1.0" }
 criterion = { version = "0.5", features = ["html_reports"] }
 der = "0.7.9"
-ed25519-dalek = "2.1.1"
+ed25519-dalek = { version = "2.1.1", features = ["pem"] }
 futures-executor = "0.3.31"
 futures-util = "0.3.31"
 getrandom = { version = "0.2", features = ["js"] }

Cargo.toml

@@ -28,7 +28,7 @@ use futures_util::future::try_join_all;
 use log::{debug, error, info, trace, warn};
 use serde::{Deserialize, Serialize};
 use sha2::{Digest, Sha256};
-use signed_note::{Verifier as NoteVerifier, VerifierList};
+use signed_note::{NoteVerifier, VerifierList};
 use static_ct_api::TreeWithTimestamp;
 use std::collections::HashMap;
 use std::time::Duration;
@@ -1189,10 +1189,10 @@ mod tests {
         Rng, RngCore, SeedableRng,
     };
     use signed_note::{Note, VerifierList};
-    use static_ct_api::{PrecertData, StandardEd25519CheckpointSigner, StaticCTCheckpointSigner};
+    use static_ct_api::{PrecertData, StaticCTCheckpointSigner};
     use static_ct_api::{StaticCTLogEntry, StaticCTPendingLogEntry};
     use std::cell::RefCell;
-    use tlog_tiles::{Checkpoint, TlogTile};
+    use tlog_tiles::{Checkpoint, Ed25519CheckpointSigner, TlogTile};
 
     #[test]
     fn test_sequence_one_leaf_short() {
@@ -1510,11 +1510,9 @@ mod tests {
         .unwrap_err();
 
         let mut c = log.config.clone_without_signers();
-        let checkpoint_signer = StandardEd25519CheckpointSigner::new(
-            &c.origin,
-            Ed25519SigningKey::generate(&mut OsRng),
-        )
-        .unwrap();
+        let checkpoint_signer =
+            Ed25519CheckpointSigner::new(&c.origin, Ed25519SigningKey::generate(&mut OsRng))
+                .unwrap();
         c.checkpoint_signers = vec![Box::new(checkpoint_signer)];
         block_on(SequenceState::load::<StaticCTLogEntry>(
             &c,
@@ -2114,11 +2112,9 @@ mod tests {
                 let signer =
                     StaticCTCheckpointSigner::new(&origin, EcdsaSigningKey::random(&mut rng))
                         .unwrap();
-                let witness = StandardEd25519CheckpointSigner::new(
-                    &origin,
-                    Ed25519SigningKey::generate(&mut rng),
-                )
-                .unwrap();
+                let witness =
+                    Ed25519CheckpointSigner::new(&origin, Ed25519SigningKey::generate(&mut rng))
+                        .unwrap();
                 vec![Box::new(signer), Box::new(witness)]
             };
 

crates/ct_worker/src/ctlog.rs

@@ -13,13 +13,10 @@ use crate::{
 use ctlog::{CreateError, LogConfig, PoolState, SequenceState};
 use futures_util::future::join_all;
 use log::{info, warn, Level};
-use static_ct_api::{
-    StandardEd25519CheckpointSigner, StaticCTCheckpointSigner, StaticCTLogEntry,
-    StaticCTPendingLogEntry,
-};
+use static_ct_api::{StaticCTCheckpointSigner, StaticCTLogEntry, StaticCTPendingLogEntry};
 use std::str::FromStr;
 use std::time::Duration;
-use tlog_tiles::{CheckpointSigner, LogEntry, PendingLogEntry};
+use tlog_tiles::{CheckpointSigner, Ed25519CheckpointSigner, LogEntry, PendingLogEntry};
 use tokio::sync::Mutex;
 #[allow(clippy::wildcard_imports)]
 use worker::*;
@@ -51,10 +48,9 @@ impl DurableObject for Sequencer {
             let signer = StaticCTCheckpointSigner::new(origin, signing_key).map_err(|e| {
                 Error::RustError(format!("could not create static-ct checkpoint signer: {e}"))
             })?;
-            let witness =
-                StandardEd25519CheckpointSigner::new(origin, witness_key).map_err(|e| {
-                    Error::RustError(format!("could not create ed25519 checkpoint signer: {e}"))
-                })?;
+            let witness = Ed25519CheckpointSigner::new(origin, witness_key).map_err(|e| {
+                Error::RustError(format!("could not create ed25519 checkpoint signer: {e}"))
+            })?;
 
             let out: Vec<Box<dyn CheckpointSigner>> = vec![Box::new(signer), Box::new(witness)];
             Ok(out)

crates/ct_worker/src/sequencer_do.rs

@@ -23,7 +23,6 @@ crate-type = ["rlib"]
 
 [dependencies]
 base64.workspace = true
-byteorder.workspace = true
 ed25519-dalek = { workspace = true, features=["alloc", "rand_core"] }
 rand_core.workspace = true
 sha2.workspace = true

crates/signed_note/Cargo.toml

@@ -13,7 +13,7 @@
 //! - [note_test.go](https://cs.opensource.google/go/x/mod/+/refs/tags/v0.21.0:sumdb/note/note_test.go)
 
 use criterion::{criterion_group, criterion_main, Criterion};
-use signed_note::{Note, NoteError, StandardVerifier, VerifierList};
+use signed_note::{Ed25519NoteVerifier, Note, NoteError, VerifierList};
 use std::hint::black_box;
 
 fn benchmark_verify(c: &mut Criterion) {
@@ -23,7 +23,7 @@ fn benchmark_verify(c: &mut Criterion) {
                \n\
                — PeterNeumann x08go/ZJkuBS9UG/SffcvIAQxVBtiFupLLr8pAcElZInNIuGUgYN1FFYC2pZSNXgKvqfqdngotpRZb6KE6RyyBwJnAM=\n".as_bytes();
 
-    let verifier = StandardVerifier::new(vkey).unwrap();
+    let verifier = Ed25519NoteVerifier::new(vkey).unwrap();
 
     c.bench_function("Sig0", |b| {
         b.iter(|| {