Remove swap_checkpoint

Author: Michael Rosenberg

crates/generic_log_worker/src/log_ops.rs

@@ -992,7 +992,7 @@ async fn sequence_entries<L: LogEntry>(
     // This is a critical error, since we don't know the state of the
     // checkpoint in the database at this point. Bail and let [SequenceState::load] get us
     // to a good state after restart.
-    swap_checkpoint(lock, sequence_state.checkpoint(), &new_checkpoint)
+    lock.swap(CHECKPOINT_KEY, sequence_state.checkpoint(), &new_checkpoint)
         .await
         .map_err(|e| {
             SequenceError::Fatal(format!("couldn't upload checkpoint to database: {e}"))
@@ -1356,20 +1356,6 @@ fn marshal_staged_uploads(
         .collect::<Vec<_>>())
 }
 
-/// Does a compare-and-swap of checkpoints. Useful for updating a checkpoint
-/// to include new cosignatures
-///
-/// # Errors
-/// Errors when `old` doesn't match the current checkpoint, or if fetching or
-/// setting storage failed.
-pub(crate) async fn swap_checkpoint(
-    lock: &impl LockBackend,
-    old: &[u8],
-    new: &[u8],
-) -> Result<(), WorkerError> {
-    lock.swap(CHECKPOINT_KEY, old, new).await
-}
-
 /// [`UploadOptions`] are used as part of the [`ObjectBackend::upload`] method, and are
 /// marshaled to JSON and stored in the staging bundles.
 #[derive(Debug, Default, Serialize, Clone, Deserialize)]

crates/generic_log_worker/src/sequencer_do.rs

@@ -308,16 +308,6 @@ impl<L: LogEntry> GenericSequencer<L> {
         }
     }
 
-    /// Does a compare-and-swap of checkpoints. Useful for updating a checkpoint
-    /// to include new cosignatures
-    ///
-    /// # Errors
-    /// Errors when `old` doesn't match the current checkpoint, or if fetching
-    /// or setting storage failed.
-    pub async fn swap_checkpoint(&self, old: &[u8], new: &[u8]) -> Result<(), WorkerError> {
-        log_ops::swap_checkpoint(&self.do_state, old, new).await
-    }
-
     /// Returns an inclusion proof for the given leaf index
     ///
     /// # Errors