Add breakdown of full vs partial tiles to metrics

Author: lukevalenta

crates/ct_worker/src/ctlog.rs

@@ -678,7 +678,10 @@ async fn sequence_entries(
         // If the data tile is full, stage it.
         if n % u64::from(TlogTile::FULL_WIDTH) == 0 {
             stage_data_tile(n, &mut edge_tiles, &mut tile_uploads, &data_tile);
-            metrics.seq_data_tile_size.observe(data_tile.len().as_f64());
+            metrics
+                .seq_data_tile_size
+                .with_label_values(&["full"])
+                .observe(data_tile.len().as_f64());
             data_tile.clear();
         }
 
@@ -692,7 +695,10 @@ async fn sequence_entries(
     // Stage leftover partial data tile, if any.
     if n != old_size && n % u64::from(TlogTile::FULL_WIDTH) != 0 {
         stage_data_tile(n, &mut edge_tiles, &mut tile_uploads, &data_tile);
-        metrics.seq_data_tile_size.observe(data_tile.len().as_f64());
+        metrics
+            .seq_data_tile_size
+            .with_label_values(&["partial"])
+            .observe(data_tile.len().as_f64());
     }
 
     // Produce and stage new tree tiles.

crates/ct_worker/src/metrics.rs

@@ -29,7 +29,7 @@ pub(crate) struct Metrics {
     pub(crate) seq_delay: Histogram,
     pub(crate) seq_leaf_size: Histogram,
     pub(crate) seq_tiles: Counter,
-    pub(crate) seq_data_tile_size: Histogram,
+    pub(crate) seq_data_tile_size: HistogramVec,
 
     pub(crate) tree_time: Gauge,
     pub(crate) tree_size: Gauge,
@@ -114,9 +114,10 @@ impl Metrics {
             r
         )
         .unwrap();
-        let seq_data_tile_size = register_histogram_with_registry!(
+        let seq_data_tile_size = register_histogram_vec_with_registry!(
             "sequencing_data_tiles_bytes",
             "Size of uploaded data tiles, including partials.",
+            &["type"],
             vec![10_000.0, 100_000.0, 1_000_000.0],
             r
         )