/tmp is being abused

[halradaideh]

Confirmation

• My issue isn't already found on the issue tracker.
• I have replicated my issue using the latest version of the library and it is still present.

cf-terraforming version

v0.23.3

Expected outcome

to clean the /tmp up after the command is executed

Actual outcome

/tmp data is accumulating causing disk issues on path Linux and macOS

Steps to reproduce

run the tool

References

No response

[gui-baeta]

@halradaideh
Yes
I was having this issue

It gets filled with tfinstall* and archives of the terraform tool.

I haven't looked into how cf-terraforming gets the terraform binary from the PATH, but when I run it it doesn't seem to find it.
I have it in my PATH and it still doesn't use it. It chooses to download the terraform tool for each run.

I am using Nix, so I thought my problem was unique to Nix, since it handles paths to binaries differently: The location of binaries is not in places such as /usr/local/bin.

The fix I am using

cf-terraforming allows you to specify the terraform binary - See this README section

So what I am doing is providing cf-terraforming with the binary I want it to use. You can do something like:

export CLOUDFLARE_TERRAFORM_BINARY_PATH=<the-path-to-terraform-binary>

# do all your `cf-terraforming` commands after...
cf-terraforming ....

To find your terraform bin., you can use the linux tool whereis:

$ whereis terraform
# Mine produced this path. Because I am using Nix, mine is in /nix/store/
terraform: /nix/store/hk3y36laijnmf1fs5czgqql1kgkpg8zj-terraform-1.11.0/bin/terraform

In my use case, I am using Nix flakes. My config looks something like this: (this is as devShell derivation)

        devShell = pkgs.mkShellNoCC {
          name = "";
          buildInputs = with pkgs; [
            terraform
            cf-terraforming
            # ... other useful tools
          ];
          src = null;
          postShellHook = ''
            # 
            # NOTE: This may not be needed, as `terraform` is already in the path created by nix
            export PATH="${pkgs.terraform}/bin:$PATH"
            # 
            # Specifies the Terraform binary to cf-terraforming tool.
            #   : for some reason cf-terraforming doesn't find the terraform binary in the PATH
            export CLOUDFLARE_TERRAFORM_BINARY_PATH="${pkgs.terraform}/bin/terraform"
          '';
        };

I have a note in there. I haven't had the time to test if that is also needed or not. It shouldn't since cf-terraforming will look for the binary path in CLOUDFLARE_TERRAFORM_BINARY_PATH

Hope this helps.

[jhutchings1]

@jacobbednarz I wonder if this is the root of the disk rot issue I was seeing in my testing earlier?

[jacobbednarz]

yes it is; there is deeper analysis on our internal ticket. if you provide a predefined binary for terraform as part of the command, you avoid filling up temporary space with go build dependencies.