[Containers] Document per-container observability in Wrangler - #33310
Open
ichernetsky-cf wants to merge 1 commit into
Open
[Containers] Document per-container observability in Wrangler#33310ichernetsky-cf wants to merge 1 commit into
ichernetsky-cf wants to merge 1 commit into
Conversation
ichernetsky-cf
requested review from
a team,
MattieTK,
irvinebroque,
th0m and
vy-ton
as code owners
September 8, 2026 17:37
github-actions
Bot
added
product:workers
Contributor
Review💡 1 suggestion found in commit 👉 Fix in your agent 👈Fix the following review findings in PR #33310 (https://github.com/cloudflare/cloudflare-docs/pull/33310).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Suggestions (1)
#### CR-b4d3022c2095 · Undocumented head_sampling_rate
- **File:** `src/content/docs/workers/wrangler/configuration.mdx` line 1313
- **Issue:** The new container-level `observability` docs (lines 1310-1331) document only `enabled`, `logs.enabled`, and the `target_instance_percentage`/`target_instance_count` rollout keys, but never `head_sampling_rate` — even though those rollout keys are described as applying "application-level observability changes" (lines 1322, 1328) and the only application-level observability change documented on this page is the top-level `observability.head_sampling_rate` (lines 407-409). Combined with the stated override semantics ("If set, it overrides the top-level `observability` setting for that container"), a reader who sets per-container `observability.enabled` cannot determine whether the top-level `head_sampling_rate` still applies to that container's logs, and there is no documented per-container way to set sampling.
- **Fix:** Document a container-level `observability.head_sampling_rate` key, or explicitly clarify how the per-container `observability` object interacts with the top-level sub-keys (e.g., that `head_sampling_rate` is inherited/merged rather than dropped when only `enabled` is set).
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Suggestions (1)
ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
2 tasks
Author
|
This is a revival of #31591 with the comments addressed. |
nikitassharma
approved these changes
Sep 8, 2026
Contributor
ichernetsky-cf
force-pushed
the
ichernetsky/top-level-observability
branch
from
September 8, 2026 17:58
ca6d1c5 to
394f740
Compare
Author
|
The last push is to update the changelog date. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://ichernetsky-top-level-observability.previews.developers.cloudflare.com (commit f24c4a5)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
ichernetsky-cf
force-pushed
the
ichernetsky/top-level-observability
branch
2 times, most recently
from
September 8, 2026 20:27
724237b to
6750600
Compare
Document `containers[].observability` for Wrangler Containers. Add the new container-level observability fields to the Wrangler configuration reference, including root `observability` fallback, per-container override behavior, and the targeting fields. Also update the Containers FAQ and pricing docs to clarify that logs can be enabled either at the Worker level or per container.
ichernetsky-cf
force-pushed
the
ichernetsky/top-level-observability
branch
from
September 8, 2026 21:34
6750600 to
f24c4a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document
containers[].observabilityfor Wrangler Containers.Add the new container-level observability fields to the Wrangler configuration reference, including root
observabilityfallback, per-container override behavior, and the targeting fields.Also update the Containers FAQ and pricing docs to clarify that logs can be enabled either at the Worker level or per container.
Documentation checklist