Skip to content

[Logs] Update Logpush dataset field definitions (2026-06-09)#31335

Open
soheiokamoto wants to merge 1 commit into
productionfrom
sync/log-fields-2026-06-09
Open

[Logs] Update Logpush dataset field definitions (2026-06-09)#31335
soheiokamoto wants to merge 1 commit into
productionfrom
sync/log-fields-2026-06-09

Conversation

@soheiokamoto

@soheiokamoto soheiokamoto commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Automated sync of Logpush dataset field definitions from data/entities.

New datasets

  • WebSocket Analytics: A new dataset with fields including BytesReceivedClient, BytesReceivedOrigin, BytesSentClient, BytesSentOrigin, ClientASN, ClientIP, ClientRequestHost, ClientRequestPath, ClientRequestUserAgent, ColoCode, ConnectionCloseReason, ConnectionCloseSource, ConnectionID, ConnectionTransportCloseCode, EdgeEndTimestamp, EdgeStartTimestamp, and RayID.
  • WebSocket Analytics: A new dataset with fields including BytesReceivedClient, BytesReceivedOrigin, BytesSentClient, BytesSentOrigin, ClientASN, ClientIP, ClientRequestHost, ClientRequestPath, ClientRequestUserAgent, ColoCode, ConnectionCloseReason, ConnectionCloseSource, ConnectionID, ConnectionTransportCloseCode, EdgeEndTimestamp, EdgeStartTimestamp, and RayID.

Files changed

  • src/content/docs/logs/logpush/logpush-job/datasets/account/ — dataset pages
  • src/content/docs/logs/logpush/logpush-job/datasets/zone/ — dataset pages
  • src/content/changelog/logs/2026-06-09-log-fields-updated.mdx — changelog

Documentation checklist

  • Changelog entry added
  • Content generated by code generator (DO NOT EDIT manually)

@soheiokamoto

soheiokamoto commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

/bonk please review this automated sync of Logpush dataset field definitions.

Focus on the following:

  1. Changelog quality — is the entry clear, accurate, and useful to end users?

  2. Field description quality — are the descriptions accurate, clear, and complete?

  3. Manual edits at risk of being overwritten — are there any field descriptions that appear
    to have been manually edited directly in cloudflare-docs (e.g. contain context or guidance
    not present in the machine-generated description format)? If so, flag them so the author can
    preserve those edits in the internal source YAML.

@soheiokamoto soheiokamoto requested review from a team and rianvdm as code owners June 9, 2026 12:33
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review

⚠️ 1 warning and 1 suggestion found in commit a9cb58c.

Warnings (1)
File Issue
changelog/logs/2026-06-09-log-fields-updated.mdx line 9 Heading levels must be sequential — First body heading is ### New datasets (H3) with no preceding H2 Fix: Change to ## New datasets
Suggestions (1)
File Issue
changelog/logs/2026-06-09-log-fields-updated.mdx line 11 Bullet list should have fewer than three items — Added bullet list contains only two items Fix: Consider rewriting the list as prose instead
Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/changelog/ @cloudflare/pm-changelogs, @cloudflare/product-owners
/src/content/docs/logs/ @soheiokamoto, @angelampcosta, @rianvdm, @dcpena, @cloudflare/product-owners

ask-bonk[bot]
ask-bonk Bot reviewed Jun 9, 2026
View reviewed changes

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of automated Logpush dataset sync.

Issue found:

  • HIGH | — The changelog lists WebSocket Analytics twice with identical text. This appears to be a code generator bug; there is only one new dataset type (available in both account and zone scopes), so it should appear once in the New datasets section.

Comment thread src/content/changelog/logs/2026-06-09-log-fields-updated.mdx
Comment on lines +11 to +12
- **WebSocket Analytics**: A new dataset with fields including `BytesReceivedClient`, `BytesReceivedOrigin`, `BytesSentClient`, `BytesSentOrigin`, `ClientASN`, `ClientIP`, `ClientRequestHost`, `ClientRequestPath`, `ClientRequestUserAgent`, `ColoCode`, `ConnectionCloseReason`, `ConnectionCloseSource`, `ConnectionID`, `ConnectionTransportCloseCode`, `EdgeEndTimestamp`, `EdgeStartTimestamp`, and `RayID`.
- **WebSocket Analytics**: A new dataset with fields including `BytesReceivedClient`, `BytesReceivedOrigin`, `BytesSentClient`, `BytesSentOrigin`, `ClientASN`, `ClientIP`, `ClientRequestHost`, `ClientRequestPath`, `ClientRequestUserAgent`, `ColoCode`, `ConnectionCloseReason`, `ConnectionCloseSource`, `ConnectionID`, `ConnectionTransportCloseCode`, `EdgeEndTimestamp`, `EdgeStartTimestamp`, and `RayID`.

@ask-bonk ask-bonk Bot Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove duplicate entry. The WebSocket Analytics dataset is listed twice; since this is a single dataset available in both account and zone scopes, it should only appear once in the changelog.

BytesReceivedClientBytesReceivedOriginBytesSentClientBytesSentOriginClientASNClientIPClientRequestHostClientRequestPathClientRequestUserAgentColoCodeConnectionCloseReasonConnectionCloseSourceConnectionIDConnectionTransportCloseCodeEdgeEndTimestampEdgeStartTimestampRayID

ask-bonk[bot]
ask-bonk Bot reviewed Jun 9, 2026
View reviewed changes

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up review with a corrected suggestion to remove the duplicate changelog entry.

Comment thread src/content/changelog/logs/2026-06-09-log-fields-updated.mdx
Comment on lines +12 to +13
- **WebSocket Analytics**: A new dataset with fields including `BytesReceivedClient`, `BytesReceivedOrigin`, `BytesSentClient`, `BytesSentOrigin`, `ClientASN`, `ClientIP`, `ClientRequestHost`, `ClientRequestPath`, `ClientRequestUserAgent`, `ColoCode`, `ConnectionCloseReason`, `ConnectionCloseSource`, `ConnectionID`, `ConnectionTransportCloseCode`, `EdgeEndTimestamp`, `EdgeStartTimestamp`, and `RayID`.

@ask-bonk ask-bonk Bot Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the duplicate. WebSocket Analytics is a single dataset available in both account and zone scopes.

Suggested change
- **WebSocket Analytics**: A new dataset with fields including `BytesReceivedClient`, `BytesReceivedOrigin`, `BytesSentClient`, `BytesSentOrigin`, `ClientASN`, `ClientIP`, `ClientRequestHost`, `ClientRequestPath`, `ClientRequestUserAgent`, `ColoCode`, `ConnectionCloseReason`, `ConnectionCloseSource`, `ConnectionID`, `ConnectionTransportCloseCode`, `EdgeEndTimestamp`, `EdgeStartTimestamp`, and `RayID`.
For the complete field definitions for each dataset, refer to [Logpush datasets](/logs/logpush/logpush-job/datasets/).

@ask-bonk

ask-bonk Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review complete. Posted review comments on PR #31335.

Findings:

  • CRITICAL | src/content/changelog/logs/2026-06-09-log-fields-updated.mdx:11–12 — The changelog lists WebSocket Analytics twice with identical text. This appears to be a code generator bug; it's a single dataset available in both account and zone scopes, so it should only appear once in the New datasets section. I posted a multi-line suggestion to remove the duplicate line.

  • Field descriptions — Accurate, clear, and complete. Descriptions are appropriately contextualized for WebSocket connections (e.g., "WebSocket upgrade request", "timestamp at which the WebSocket connection was established"). The format matches existing machine-generated dataset pages.

  • Manual edits at risk — None. Both websocket_analytics.md files are brand new (ADDED in this PR), so no previous cloudflare-docs content is being overwritten.

github run

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

CI run failed: build logs

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Broken Links

Found 1 broken link(s) across 1 file(s).

File Link Position Error
dns/faq.mdx /email-routing/ 112:117 invalid link

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Preview URL: https://a9cb58c1.preview.developers.cloudflare.com
Preview Branch URL: https://sync-log-fields-2026-06-09.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/changelog/post/2026-06-09-log-fields-updated/ https://sync-log-fields-2026-06-09.preview.developers.cloudflare.com/changelog/post/2026-06-09-log-fields-updated/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ask-bonk ask-bonk[bot] ask-bonk[bot] left review comments

@rianvdm rianvdm Awaiting requested review from rianvdm rianvdm is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@rianvdm rianvdm

Labels

product:changelog product:logs Related to Logs size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@soheiokamoto @rianvdm