Skip to content

[Sandbox] Add a changelog entry for deprecated APIs#31338

Open
aron-cf wants to merge 9 commits into
productionfrom
sandbox-deprecations
Open

[Sandbox] Add a changelog entry for deprecated APIs#31338
aron-cf wants to merge 9 commits into
productionfrom
sandbox-deprecations

Conversation

@aron-cf

@aron-cf aron-cf commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

This adds a new changelog entry that documents upcoming changes to the Sandbox SDK API.

It also adds a couple of stubs for supporting documents that need to be added before the changelog can ship.

Documentation checklist

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review

⏸️ Automatic reviews for this PR are paused.

This PR has already received 2 automatic reviews. To run another review, a codeowner can comment /review or /full-review.

Tip: Keep PRs in draft mode until they are ready for review — the bot skips draft PRs automatically.


⚠️ 3 warnings found in commit 1eee913.

Warnings (3)
File Issue
sandbox/guides/2026-deprecation.mdx line 41 Links should use root-relative paths — Internal link uses full https URL Fix: Change to root-relative path
changelog/sandbox/2026-06-09-deprecating-sandbox-sdk-features.mdx line 10 Directional words — The features below have either been superseded Fix: Replace below with direct reference
changelog/sandbox/2026-06-09-deprecating-sandbox-sdk-features.mdx line 40 Internal link file extension — Looks like internal link with extension Fix: Remove file extension from link
Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
package.json @cloudflare/content-engineering
* @cloudflare/product-owners
/src/content/changelog/ @cloudflare/pm-changelogs, @cloudflare/product-owners
/src/content/docs/sandbox/ @whoiskatrin, @ghostwriternr, @scuffi, @aron-cf, @thomasgauvin, @cloudflare/product-owners, @cloudflare/ai-agents

@ask-bonk ask-bonk Bot added the changelog Adds or updates changelog entries/pages. label Jun 9, 2026

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted 4 inline suggestions.

Summary

  • HIGH (): Internal link uses full URL.
  • MEDIUM (): Relative time phrases ('the next 30 days', 'in 30 days', 'In April') become stale. Use absolute dates in changelogs.
  • LOW (): Discord link uses non-standard URL.

Comment thread src/content/changelog/sandbox/2026-06-09-deprecating-sandbox-sdk-features.mdx Outdated
Comment thread src/content/changelog/sandbox/2026-06-09-deprecating-sandbox-sdk-features.mdx Outdated
Comment thread src/content/changelog/sandbox/2026-06-09-deprecating-sandbox-sdk-features.mdx Outdated
Comment thread src/content/docs/sandbox/guides/2026-deprecation.mdx Outdated

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing with 4 inline suggestions.

Summary

  • HIGH (2026-deprecation.mdx:41): Internal link uses full developers.cloudflare.com URL.
  • MEDIUM (2026-06-09-deprecating-sandbox-sdk-features.mdx:11,15): Relative time phrases ("the next 30 days", "in 30 days", "In April") become stale. Use absolute dates in changelogs.
  • LOW (2026-06-09-deprecating-sandbox-sdk-features.mdx:43): Discord link uses non-standard URL.

Comment thread src/content/changelog/sandbox/2026-06-09-deprecating-sandbox-sdk-features.mdx Outdated
Comment thread src/content/changelog/sandbox/2026-06-09-deprecating-sandbox-sdk-features.mdx Outdated
Comment thread src/content/changelog/sandbox/2026-06-09-deprecating-sandbox-sdk-features.mdx Outdated
Comment thread src/content/docs/sandbox/guides/2026-deprecation.mdx Outdated
whoiskatrin and others added 4 commits June 9, 2026 15:57
…dk-features.mdx

Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
…dk-features.mdx

Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
…dk-features.mdx

Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No remaining issues. The previously flagged items (relative dates, internal full-URL links, and Discord URL) were all addressed in the follow-up commits. pnpm run check passes cleanly.

@ask-bonk

ask-bonk Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review complete — approved on 864a23c3.

What I did

  • Applied labels: product:sandbox, changelog.
  • Reviewed the initial diff (053a5678) and found three issues:
    • HIGH (2026-deprecation.mdx): Internal link used full developers.cloudflare.com URL.
    • MEDIUM (changelog): Relative time phrases ("for the next 30 days", "in 30 days", "In April") that would become stale.
    • LOW (changelog): Discord link used non-standard URL.
  • Posted inline suggestions for all three issues.
  • Verified pnpm run check passes with 0 errors.

Follow-up

The author pushed four follow-up commits (053a567..864a23c) that addressed every suggestion:

  • Absolute dates (July 9, 2026) replace relative time.
  • Root-relative path used for the internal SKILL.md link.
  • Discord URL updated to https://discord.gg/cloudflaredev.

Remaining assessment

No remaining issues. The changelog frontmatter, migration guide frontmatter, link targets, and MDX syntax are all valid.

github run

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

CI run failed: build logs

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Broken Links

Found 1 broken link(s) across 1 file(s).

File Link Position Error
cloudflare-one/team-and-resources/devices/cloudflare-one-client/business-continuity.mdx /cloudflare-one/team-and-resources/devices/cloudflare-one-client/configure/settings/external-disconnect/ 289:35 invalid link

Resolve the DNS FAQ conflict by keeping the production Email Service link. Add @astrojs/markdown-remark as a direct dev dependency so Astro 6 prerender can resolve the generated markdown processor import during build.
@whoiskatrin whoiskatrin requested a review from a team as a code owner June 9, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog Adds or updates changelog entries/pages. product:changelog product:sandbox size/m

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants