Fix duplicated "unexpected shutdowns" paragraph in Rules of Durable Objects#31345
Open
krupa-dot wants to merge 1 commit into
Open
Fix duplicated "unexpected shutdowns" paragraph in Rules of Durable Objects#31345krupa-dot wants to merge 1 commit into
krupa-dot wants to merge 1 commit into
Conversation
krupa-dot
requested review from
a team,
Oxyjun,
danlapid,
elithrar,
iglesiasbrandon,
irvinebroque,
joshthoward,
lambrospetrou,
mikenomitch,
rita3ko and
vy-ton
as code owners
github-actions
Bot
added
product:durable-objects
github-actions
Bot
assigned
danlapid,
elithrar,
iglesiasbrandon,
irvinebroque,
joshthoward,
lambrospetrou,
mikenomitch,
Oxyjun,
rita3ko and
vy-ton
Contributor
Review❌ Review failed for commit |
…bjects The paragraph under "Design for unexpected shutdowns" rendered twice: an inline hardcoded copy plus the working-without-shutdown-hooks partial, which begins with the same sentence. Remove the inline paragraph so the partial is the single source of truth, and preserve the "at any time" wording by adding it to the partial.
krupa-dot
force-pushed
the
fix/rules-of-do-duplicate-shutdown-paragraph
branch
from
8ca87d1 to
f8eb260
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: On the Rules of Durable Objects page, the paragraph under "Design for unexpected shutdowns" rendered twice — an inline hardcoded copy plus the
working-without-shutdown-hookspartial, which begins with the same sentence.Fix: Removed the inline hardcoded paragraph so the partial is the single source of truth. Preserved the slightly stronger "at any time" wording by adding it to the partial's first paragraph.
Blast radius: This partial is also rendered by
durable-objects/concepts/durable-object-lifecycle.mdx(under its "Working without shutdown hooks" heading). The "at any time" wording now appears there too and reads correctly in context; that page has no inline copy, so no new duplication is introduced.