Merge pull request #98 from cloudflare/jamesog/97-updatednsrecord

Bugfix for UpdateDNSRecord

Author: jamesog

cmd/flarectl/flarectl.go

@@ -406,6 +406,7 @@ func dnsUpdate(c *cli.Context) {
 	}
 	zone := c.String("zone")
 	recordID := c.String("id")
+	name := c.String("name")
 	content := c.String("content")
 	ttl := c.Int("ttl")
 	proxy := c.Bool("proxy")
@@ -418,6 +419,7 @@ func dnsUpdate(c *cli.Context) {
 
 	record := cloudflare.DNSRecord{
 		ID:      recordID,
+		Name:    name,
 		Content: content,
 		TTL:     ttl,
 		Proxied: proxy,
@@ -718,6 +720,10 @@ func main() {
 							Name:  "id",
 							Usage: "record id",
 						},
+						cli.StringFlag{
+							Name:  "name",
+							Usage: "record name",
+						},
 						cli.StringFlag{
 							Name:  "content",
 							Usage: "record content",

dns.go

@@ -121,7 +121,11 @@ func (api *API) UpdateDNSRecord(zoneID, recordID string, rr DNSRecord) error {
 	if err != nil {
 		return err
 	}
-	rr.Name = rec.Name
+	// Populate the record name from the existing one if the update didn't
+	// specify it.
+	if rr.Name == "" {
+		rr.Name = rec.Name
+	}
 	rr.Type = rec.Type
 	uri := "/zones/" + zoneID + "/dns_records/" + recordID
 	res, err := api.makeRequest("PUT", uri, rr)