Commit 4d41c2d
Antoni T
computer: document the second reason a pull skips
SkippedEntry became a union of two reasons when the per-command
write capability landed: an entry can be refused because it targets
a read-only mount root, or because the command ran without write
access and the post-command pull refused everything it was offered.
The comments on ExecResult.skipped and Workspace.pull still
described only the mount case, and ExecResult went further and
claimed the field is empty when no read-only mounts are registered.
That is wrong for a container command that ran read-only. Describe
both reasons, and note that a backend sharing the workspace store
never fills the field because it has no pull to refuse.1 parent 6a334d5 commit 4d41c2d
2 files changed
Lines changed: 9 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
62 | 65 | | |
63 | 66 | | |
64 | 67 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
626 | 626 | | |
627 | 627 | | |
628 | 628 | | |
629 | | - | |
| 629 | + | |
| 630 | + | |
630 | 631 | | |
631 | 632 | | |
632 | 633 | | |
| |||
0 commit comments