Clippy

Author: kornelski

crates/freighter-auth/src/cf_backend.rs

@@ -184,7 +184,7 @@ fn cookie_parse() {
     let a = CfAuthProvider::new(Config {
         auth_audience: "...".into(),
         auth_team_base_url: "https://test.example.net".into(),
-        auth_publish_access_ids: Default::default(),
+        auth_publish_access_ids: HashSet::default(),
     })
     .unwrap();
 

crates/freighter-client/src/lib.rs

@@ -302,6 +302,7 @@ impl Client {
         dl
     }
 
+    #[allow(clippy::literal_string_with_formatting_args)]
     fn apply_markers(url: &str, name: &str, version: &str, shasum: &str) -> String {
         let prefix = Self::crate_prefix(name);
         url.replace("{crate}", name)

crates/freighter-fs-index/src/lib.rs

@@ -337,13 +337,13 @@ fn convert_publish_to_crate_entry(
     versions.entries.sort_by_key(|v| Reverse(v.vers.clone()));
 
     let publish = publish.unwrap_or_else(|| Publish {
-        name: versions.entries[0].name.to_string(),
+        name: versions.entries[0].name.clone(),
         vers: versions.entries[0].vers.clone(),
         ..Publish::empty()
     });
 
     // We don't have exact dates
-    let last_modified = versions.last_modified.unwrap_or(Utc::now());
+    let last_modified = versions.last_modified.unwrap_or_else(Utc::now);
 
     ListAllCrateEntry {
         name: publish.name.clone(),